Skip to content

fix(settings): keep the new settings dot one colour in every theme - #1772

Merged
A-EDev merged 1 commit into
mainfrom
fix/new-settings-dot-colour
Nov 6, 2026
Merged

A-EDev merged 1 commit into
mainfrom
fix/new-settings-dot-colour

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The new settings dot is now one fixed green in every theme instead of the theme's primary color, so it no longer blends in with the headers or text.
  • The colors live in ui/theme/Color.kt: #3DDC84 on dark surfaces and #12782F on light ones.

Related issue

Closes #1714

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed
  • ./gradlew :app:testGithubDebugUnitTest: passed, 5064 tests, 0 failed, 2 skipped
  • ./gradlew ktlintCheck :app:compileFossDebugKotlin: passed
  • I manually tested the affected behavior on an Android device or emulator.

NewBadgeColorTest checks 3:1 contrast on the background and surface of every built-in palette. Checked by eye on the Monochrome dark theme on the phone and the Flow Default light theme on the emulator.

Test device and Android version: Xiaomi 2311DRK48G, HyperOS 3, Android 16; Android emulator, API 37

Screenshots or recordings

Risk and compatibility

Only changes the dot's color, which shows when Highlight new settings is on.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 5, 2026
@A-EDev
A-EDev merged commit 9cb338a into main Nov 6, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/new-settings-dot-colour branch November 6, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Highlight New in-app settings related

2 participants