Skip to content

Add idempotent authority mutation foundation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abiorh-claw merged 6 commits into from
Jul 14, 2026
Merged

Add idempotent authority mutation foundation #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d836f2f
docs(auth): approve idempotency plan
Abiorh001 Jul 14, 2026
6e41b4d
feat(auth): add idempotent authority mutation foundation
Abiorh001 Jul 14, 2026
e083890
fix(auth): close idempotency evidence invariants
Abiorh001 Jul 14, 2026
4cb1984
docs(auth): record idempotency review evidence
Abiorh001 Jul 14, 2026
b4f9b83
docs(auth): reconcile idempotency lifecycle evidence
Abiorh001 Jul 14, 2026
83ca3e2
docs(auth): bind final idempotency review provenance
Abiorh001 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .agent-loop/LOOP_STATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,25 @@

- Active initiative: `WS-AUTH-001` - Workstream Authorization Service
- Active planning chunk: none
- Active implementation chunk: none
- Branch: `codex/ws-auth-001-cat-post-merge-memory`
- Active implementation chunk: `WS-AUTH-001-05B` - Authority Idempotency And
Invalidation Foundation
- Branch: `codex/ws-auth-001-05b-idempotency-invalidation`
- Worktree: `/home/abiorh/flow/workstream-authorization-service`
- Status: `WS-AUTH-001-CAT` passed required internal reviews, Backend, Agent
Gates, CodeRabbit, and explicit human approval, then merged through PR #117 as
`4c5d4fc` on 2026-07-14. Post-merge memory is the only active work.
- Status: CAT post-merge memory merged through PR #118 as `eba7e2b` on
2026-07-14. `WS-AUTH-001-05B` implementation and repair are complete at
reviewed runtime SHA `e083890`; every required internal review track passed.
- Prior `WS-AUTH-001-01` reviewed implementation SHA: `be0b836`
- Prior `WS-AUTH-001-01` final merged branch head: `b5217e1`
- Latest integrated `main` merge commit: `4c5d4fc`
- Current gate: CAT post-merge memory and stop; no runtime implementation chunk
is active.
- Latest integrated `main` merge commit: `eba7e2b`
- Current gate: PR publication, GitHub checks, CodeRabbit, and human review.
Comment on lines +11 to +17

@coderabbitai coderabbitai Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Synchronize all current lifecycle artifacts with published PR #119.

The same stale “PR publication pending” state appears across the active loop documents. Since the supplied PR objective identifies this review as PR #119, publication is complete; retain only the remaining checks, external review, human approval, merge, memory-update, and stop gates.

  • .agent-loop/LOOP_STATE.md#L11-L17: update the current gate and status.
  • .agent-loop/WORK_QUEUE.md#L7-L7: change the AUTH-05B status.
  • .agent-loop/WORK_QUEUE.md#L64-L67: update the proposed-next narrative.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/CHUNK_MAP.md#L24-L24: update the chunk status.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/CHUNK_MAP.md#L112-L114: update the stop-condition wording.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L62-L65: update the progress summary.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L74-L75: update the active implementation gate.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L96-L96: update the chunk table.
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L127-L129: update the blocker/gate narrative.
📍 Affects 4 files
  • .agent-loop/LOOP_STATE.md#L11-L17 (this comment)
  • .agent-loop/WORK_QUEUE.md#L7-L7
  • .agent-loop/WORK_QUEUE.md#L64-L67
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/CHUNK_MAP.md#L24-L24
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/CHUNK_MAP.md#L112-L114
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L62-L65
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L74-L75
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L96-L96
  • .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md#L127-L129
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.agent-loop/LOOP_STATE.md around lines 11 - 17, Synchronize the lifecycle
artifacts with published PR `#119` by removing the stale “PR publication pending”
state and retaining only checks, external review, human approval, merge,
memory-update, and stop gates. Update .agent-loop/LOOP_STATE.md lines 11-17,
.agent-loop/WORK_QUEUE.md lines 7 and 64-67, CHUNK_MAP.md lines 24 and 112-114,
and STATUS.md lines 62-65, 74-75, 96, and 127-129; ensure each status, progress
summary, chunk entry, proposed-next narrative, active gate, blocker narrative,
and stop condition reflects the post-publication state.

- Scope checkpoint: the 52 approved identifiers and `/api/v1` namespace remain
unchanged. AUTH-05A's 49-identifier audit base remains runtime truth until the
three planned recovery identifiers receive typed/SQL parity in AUTH-13/14.
- Next chunk: the user explicitly directed AUTH-05B to continue after this
reconciliation. Its start signal is recorded and it may activate after this
post-merge memory update merges, without another start signal.
- Focused evidence: the audit/delegation suite passed 11 tests at 94.55 percent
audit-subsystem coverage. Final GitHub Backend passed 949 tests at 82.77
percent global coverage and 91.07 percent artifact-foundation coverage.
- Next chunk: `WS-AUTH-001-06` remains inactive. Do not start it automatically.
- Focused evidence: 26 AUTH-05B authorization/audit/migration tests passed at
96.88 percent authorization-subsystem coverage. The prior main Backend result
remains 949 tests at 82.77 percent global coverage and 91.07 percent
artifact-foundation coverage; GitHub CI will produce the new full result.
- Parallel initiative: `WS-QUAL-001-01B2` is paused at the user's direction so
AUTH receives the laptop's test capacity. Its last official whole-app result
remains `6466/8159` statements (`79.249908%`); no replacement evidence exists.
Expand Down
32 changes: 32 additions & 0 deletions .agent-loop/REVIEW_LOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# Review Log

## 2026-07-14 - WS-AUTH-001-05B Internal Review Passed

Reviewed runtime SHA `e083890` passed senior engineering, architecture,
product/ops, docs, reuse/dedup, QA/test, test delta, CI integrity, and
security/auth/privacy review after repair. Valid findings closed committed-row
evidence injection, request/result target substitution, incomplete linked-event
context, mismatch scope/resource semantics, rejected-value retention, and
missing migration/operation behavior proof. The focused suite passed 26 tests
at 96.88 percent authorization-subsystem coverage. PR publication and external
checks remain pending; AUTH-06 is inactive.

## 2026-07-14 - WS-AUTH-001-05B Repaired Plan Passed

The repaired L1 plan passes senior engineering, QA/test, and
security/auth/privacy review. The approved contract closes the ten-operation
registry, strict canonical request variants, actor-bound audit linkage,
single-use claim state machine, immutable database enforcement, clean mismatch
transaction, exact event counts, migration compatibility, and hostile-input
privacy evidence. Bounded runtime implementation may begin; AUTH-06 remains
inactive.

## 2026-07-14 - WS-AUTH-001-05B L1 Plan Review Repair

PR #118 merged CAT post-merge memory as `eba7e2b`, satisfying the recorded
AUTH-05B activation gate. The first 05B L1 preimplementation review rejected
runtime edits until the contract closed the exact operation registry, strict
canonical request/response/result types, opaque claim ownership, committed-row
immutability, clean mismatch-denial transaction, narrow invalidation ownership,
and deterministic downgrade guard. The repair also replaces the numeric line
ceiling with the user-directed semantic chunk boundary. Runtime code remains
unmodified pending repaired plan approval.

## 2026-07-14 - WS-AUTH-001-CAT Merged

PR #117 merged through explicit human approval as `4c5d4fc`. Final branch head
Expand Down
13 changes: 6 additions & 7 deletions .agent-loop/WORK_QUEUE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

| Chunk | Title | Risk | Status |
|---|---|---:|---|
| `WS-AUTH-001-CAT-MEMORY` | Catalogue Post-Merge Memory | L1 | PR #117 merge confirmed; memory update active |
| `WS-AUTH-001-05B` | Authority Idempotency And Invalidation Foundation | L1 | Implemented; internal review complete; PR publication pending |

## Planned Next

| Chunk | Title | Risk | Status |
|---|---|---:|---|
| `WS-AUTH-001-05B` | Authority Idempotency And Invalidation Foundation | L1 | Start signal received; activate after CAT post-merge memory merges |
| `WS-AUTH-001-06` | Canonical Actor Profile And Identity Link | L1 | Inactive until AUTH-05B merge/memory and a separate explicit user start |
| `WS-QUAL-001-01B2` | Baseline Evidence And CI Ratchet | L1 | Paused for AUTH priority; no valid replacement baseline yet |
| `WS-QUAL-001-02` | Project Service Coverage | L1 | Inactive until 01B2 merge/memory plus explicit user start |
| `WS-POL-002-04` | Locked Runtime Execution And Routing Hardening | L1 | Inactive pending relevant authorization proof and a separate explicit user start |
Expand Down Expand Up @@ -57,14 +57,13 @@
| `WS-AUTH-001-04B` | PostgreSQL Rate Controls | L1 | Merged through PR #113 as `05a63c8` on 2026-07-14 |
| `WS-AUTH-001-05A` | Shared Audit Ownership And Append-Only Authority Evidence | L1 | Merged through PR #115 as `8e1cde6` on 2026-07-14 |
| `WS-AUTH-001-CAT` | Action And Resource Catalogue Reconciliation | L1 | Merged through PR #117 as `4c5d4fc` on 2026-07-14 |
| `WS-AUTH-001-CAT-MEMORY` | Catalogue Post-Merge Memory | L1 | Merged through PR #118 as `eba7e2b` on 2026-07-14 |

## Proposed Next

AUTH-05A merged through PR #115 as `8e1cde6` after required internal reviews,
Backend, Agent Gates, CodeRabbit, and explicit human approval passed. The user
has given the AUTH-05B start signal. AUTH-05B remains inactive only until
the CAT post-merge memory update merges; no second start signal is required. Do
not start AUTH-05B before that final memory gate, or start AUTH-06 or POL-002-04
AUTH-05A merged through PR #115 as `8e1cde6`, and CAT plus its post-merge memory
merged through PRs #117 and #118. AUTH-05B implementation and internal review
are complete; PR publication is pending. Do not start AUTH-06 or POL-002-04
automatically.

Coverage R10 merged through PR #108. Do not start 01B2, chunk 02, or another
Expand Down
7 changes: 4 additions & 3 deletions .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/CHUNK_MAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ stopped.
| `WS-AUTH-001-05` | Authority Evidence And Idempotency Foundation | L1 | Split before implementation into 05A and 05B |
| `WS-AUTH-001-05A` | Shared Audit Ownership And Append-Only Authority Evidence | L1 | Merged through PR #115 as `8e1cde6` |
| `WS-AUTH-001-CAT` | Action And Resource Catalogue Reconciliation | L1 | Merged through PR #117 as `4c5d4fc` |
| `WS-AUTH-001-05B` | Authority Idempotency And Invalidation Foundation | L1 | Start signal received; activate after CAT post-merge memory merges |
| `WS-AUTH-001-05B` | Authority Idempotency And Invalidation Foundation | L1 | Implemented and internally reviewed; PR publication pending |
| `WS-AUTH-001-06` | Canonical Actor Profile And Identity Link | L1 | Proposed |
| `WS-AUTH-001-07` | Authorization Kernel And Permission Registry | L1 | Proposed |
| `WS-AUTH-001-08` | Bootstrap And Administrative Role Grants | L1 | Proposed |
Expand Down Expand Up @@ -109,5 +109,6 @@ the semantic AUTH-05A boundary. Required reviews and checks passed, and explicit
human approval merged PR #115 as `8e1cde6` on 2026-07-14, followed by merged
post-merge memory. `WS-AUTH-001-CAT` then merged through PR #117 as `4c5d4fc`
after Backend, Agent Gates, CodeRabbit, and explicit human approval passed. The
AUTH-05B start signal is recorded; 05B may activate after CAT post-merge memory
merges, without another start signal. Do not start AUTH-06 or POL-002-04.
CAT post-merge memory merged through PR #118 as `eba7e2b`; AUTH-05B runtime SHA
`e083890` is internally reviewed, and PR publication is pending. Do not start
AUTH-06 or POL-002-04.
25 changes: 16 additions & 9 deletions .agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/STATUS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,24 @@ CodeRabbit passed, and explicit human approval merged PR #115 as `8e1cde6` on
The user requested action/resource catalogue reconciliation before AUTH-05B.
That docs-only work passed required internal reviews, Backend, Agent Gates, and
CodeRabbit; explicit human approval merged PR #117 as `4c5d4fc` on 2026-07-14.
Its post-merge memory merged through PR #118 as `eba7e2b`. AUTH-05B's repaired
L1 plan passed before runtime edits. Implementation, repair, focused evidence,
and all required internal review tracks now pass at reviewed runtime SHA
`e083890`; PR publication is pending.

## Active planning chunk

None. CAT post-merge memory is active; no planning chunk is active.
None. AUTH-05B implementation is internally reviewed under its approved
repaired contract.

## Active implementation chunk

None. AUTH-05B's start signal is recorded and it remains inactive only until CAT
post-merge memory merges.
`WS-AUTH-001-05B` is implemented and internally reviewed. GitHub checks,
CodeRabbit, and explicit human review remain pending.

## Current implementation branch

`codex/ws-auth-001-cat-post-merge-memory` in
`codex/ws-auth-001-05b-idempotency-invalidation` in
`/home/abiorh/flow/workstream-authorization-service`.

## Chunk status
Expand All @@ -88,7 +93,7 @@ post-merge memory merges.
| `WS-AUTH-001-05` | Split | `codex/ws-auth-001-05-authority-evidence` | - | Parent split before implementation into 05A and 05B. |
| `WS-AUTH-001-05A` | Merged | `codex/ws-auth-001-05-authority-evidence` | #115 | Merged as `8e1cde6`; reviewed code `ea16fd8`; final branch head `d023952`. |
| `WS-AUTH-001-CAT` | Merged | `codex/ws-auth-001-action-catalogue-reconciliation` | #117 | Merged as `4c5d4fc`; final branch head `5b4ec96`. |
| `WS-AUTH-001-05B` | Inactive | - | - | Start signal received; activate after CAT post-merge memory merges. |
| `WS-AUTH-001-05B` | In review | `codex/ws-auth-001-05b-idempotency-invalidation` | - | Reviewed runtime SHA `e083890`; PR publication pending. |
| `WS-AUTH-001-06` | Proposed | - | - | Canonical actor profile and identity link. |
| `WS-AUTH-001-07` | Proposed | - | - | Authorization kernel and permissions. |
| `WS-AUTH-001-08` | Proposed | - | - | Bootstrap and administrative grants. |
Expand All @@ -103,10 +108,11 @@ post-merge memory merges.

## Blockers

AUTH-05A has no remaining blocker and is merged. The combined AUTH-05 contract
AUTH-05A and CAT post-merge memory have no remaining blocker and are merged.
The combined AUTH-05 contract
was rejected before runtime changes because shared audit evidence and
idempotency/invalidation were not reviewable as one L1 change. AUTH-05A owns
migration `0018`; inactive AUTH-05B later owns migration `0019`. Non-test
migration `0018`; active AUTH-05B owns migration `0019`. Non-test
operators must later supply explicit classification evidence rather than
inferred kinds before the owning canonical actor migration.

Expand All @@ -118,8 +124,9 @@ permission identifiers remain approved, including
`operations.checker.retry`; the three recovery identifiers receive persisted
parity only in their owning later chunks. `WS-AUTH-001-CAT` retains only safe
registry/conformance rules. This is a scope decision, not an AUTH-05B runtime
blocker. PR #117 is merged; AUTH-05B begins after this post-merge memory update
merges, without another start signal.
blocker. PR #118 is merged, and AUTH-05B runtime SHA `e083890` is internally
reviewed. Its current gate is PR publication and external checks; AUTH-06 and
POL-002-04 remain inactive.

AUTH-04B review evidence and its PR trust bundle are recorded at
`reviews/WS-AUTH-001-04B-internal-review-evidence.md` and
Expand Down
Loading
Loading