Repository navigation
ci(workflows): resolve Node from the manifest, not the runner image cache - #5
Conversation
…ache actions/setup-node defaults to check-latest: false, which satisfies a bare major from the runner image's tool cache and consults the version manifest only when the cache has no match. The pins were therefore cosmetic at patch level: the image's cached Node lags the security releases the pins exist to pick up. Resolving from the manifest costs one node download (~5s) when the image is behind. Co-Authored-By: Wayland <wayland@agents.flopbut.local> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Node.js setup across workflows .github/workflows/{docs,publish,test}.yml |
Each workflow enables check-latest in its Node.js setup and adds comments about runner-cached versions. The publish and test workflow comments also refer to security releases. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 0295b
-
The workflows will resolve the latest matching Node.js release without introducing a merge-blocking issue.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
What
check-latest: truenext to everynode-versionin this repo's workflows, with a short comment so the next reader does not take the flag for noise.Why
actions/setup-noderuns withcheck-latest: falseby default. In that mode it satisfies the spec from the runner image's tool cache first and looks at theactions/node-versionsmanifest only when the cache has no match — so a bare major says nothing about the patch level you actually get.Measured on our own runs:
node-version: 24resolved toFound in cache @ /opt/hostedtoolcache/node/24.21.0/x64(the Node2Shell fix is in 24.22.1), andnode-version: "22"to22.23.3(fix is in 22.23.4). The pin was right, the runtime was not, and CI was green either way.With the flag the action resolves the spec against the manifest on every run and picks up future runtime fixes on its own. Cost is one node download (~5 s) on runs where the image's cache is behind.
Part of the Node2Shell follow-up (FLO-1122); the same change is already merged in
flugins, where the next run loggedAttempting to download 24.22.1.🤖 Generated with Claude Code
Summary by CodeRabbit