Skip to content

ci(workflows): resolve Node from the manifest, not the runner image cache - #161

Merged
Fl0p merged 1 commit into
mainfrom
flo-1122-setup-node-check-latest
Oct 24, 2026
Merged

Fl0p merged 1 commit into
mainfrom
flo-1122-setup-node-check-latest

Conversation

@Fl0p

@Fl0p Fl0p commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

What

check-latest: true next to every node-version in this repo's workflows, with a short comment so the next reader does not take the flag for noise.

Why

actions/setup-node runs with check-latest: false by default. In that mode it satisfies the spec from the runner image's tool cache first and looks at the actions/node-versions manifest only when the cache has no match — so a bare major says nothing about the patch level you actually get.

Measured on our own runs: node-version: 24 resolved to Found in cache @ /opt/hostedtoolcache/node/24.21.0/x64 (the Node2Shell fix is in 24.22.1), and node-version: "22" to 22.23.3 (fix is in 22.23.4). The pin was right, the runtime was not, and CI was green either way.

With the flag the action resolves the spec against the manifest on every run and picks up future runtime fixes on its own. Cost is one node download (~5 s) on runs where the image's cache is behind.

Part of the Node2Shell follow-up (FLO-1122); the same change is already merged in flugins, where the next run logged Attempting to download 24.22.1.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • The CI and documentation workflows now check for the latest available Node.js 22.x version instead of preferring a cached version. This keeps the Node.js version used by those workflows current when they run.

…ache

actions/setup-node defaults to check-latest: false, which satisfies a bare
major from the runner image's tool cache and consults the version manifest
only when the cache has no match. The pins were therefore cosmetic at patch
level: the image's cached Node lags the security releases the pins exist to
pick up. Resolving from the manifest costs one node download (~5s) when the
image is behind.

Co-Authored-By: Wayland <wayland@agents.flopbut.local>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0dd09f68-3d24-45ff-a934-4074256fb1a9
Commits

Reviewing files that changed from the base of the PR and between fcf273b and ba099e4.

Files selected for processing: 2
  • .github/workflows/ci.yml
  • .github/workflows/docs.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Both the CI and documentation workflows enable check-latest for Node.js 22. Comments describe the runner’s cached version behavior.

Changes: Node.js version checks

Layer / File(s) Summary
Node.js setup in workflows
.github/workflows/ci.yml, .github/workflows/docs.yml
Both workflows set check-latest: true for Node.js 22 and add comments about cached versions.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to ba099

The workflow updates are mergeable with no identified blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main workflow change: resolving Node.js versions from the manifest instead of relying on the runner image cache.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fl0p
Fl0p merged commit 9585d97 into main Oct 24, 2026
9 checks passed
@Fl0p
Fl0p deleted the flo-1122-setup-node-check-latest branch October 24, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant