Repository navigation
feat(health): the deploy host asks /healthz on a schedule, and it pages #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+612
−189
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8680a2d
feat(health): the deploy host asks /healthz on a schedule, and it pages
85810e4
fix(health): page the scheduled /healthz half under its historical ma…
60be158
fix(health): restore the separate scheduled marker the grant asked for
6662303
fix(health): the marker names the subject, so the /healthz half share…
0262a28
fix(health): assert snapshots on the deploy host, and catch the stall…
64fbac9
merge: reconcile with main, and quote the measured tick rate instead …
d85aaa8
docs(health): the scheduled probe, not a hand run, now watches the sn…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Keep dispatches from cancelling scheduled probes.
Both event types now enter the same
health-probe-loopbackconcurrency group, which hascancel-in-progress: true. If a dispatch starts during a scheduled run's 60-second red confirmation, GitHub cancels the scheduled job before it can page. A dispatch withpageunchecked does not replace that production alert. Use separate concurrency groups for schedule and dispatch so a drill cannot interrupt a watcher tick. (docs.github.com)🤖 Prompt for AI Agents
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Require a snapshot claim on scheduled production runs.
The scheduled job inherits
SNAPSHOT_CHECK=auto. If/api/v1/healthreportssnapshot.status: "unknown"or cannot provide a snapshot report,probe-healthz.shexits green. A production worker that never produces its first restore point can therefore remain unpaged. SetSNAPSHOT_CHECK=requirefor scheduled runs; that mode makes an unverified snapshot report red. (raw.githubusercontent.com)🤖 Prompt for AI Agents