Conversation
…type adapters The environment and API key mappers now return plain dicts. Dynamo documents are validated through the flagsmith_schemas TypedDicts, which coerce their values, rather than through vendored models and a custom encoder. The uncompressed environment document no longer carries the always-empty `identity_overrides`, or `entity_selector` on non-Dynatrace integrations, as the compressed one already didn't.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
api
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/8597-single-variant-identity-overrides #8606 +/- ##
=============================================================================
Coverage 98.81% 98.82%
=============================================================================
Files 1645 1630 -15
Lines 67591 67286 -305
=============================================================================
- Hits 66789 66494 -295
+ Misses 802 792 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…documents Edge identities and identity overrides are now plain flagsmith_schemas TypedDicts, validated through TypeAdapters. Stored numbers are validated as native numbers, since the schema doesn't round-trip Decimals.
khvn26
force-pushed
the
feat/drop-vendored-engine-models
branch
from
September 25, 2026 20:36
07cbca9 to
aac37fe
Compare
github-actions
Bot
added
refactor
docs
…anch Drops the Core-side workaround, now that flagsmith-common keeps stored Decimals when validating documents.
khvn26
force-pushed
the
feat/drop-vendored-engine-models
branch
from
September 26, 2026 20:54
d9ec5b7 to
0ac09ae
Compare
github-actions
Bot
added
refactor
and removed
docs
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6654
WIP. In this PR, we replace the vendored Pydantic engine models in
util/engine_modelswithflagsmith_schemasTypedDicts, validated through type adapters.So far:
flagsmith_schemasDynamo TypedDicts, replacing the vendored models and the custom document encoder.Still to do: edge identities, identity override documents, and removing
util/engine_models.The uncompressed environment document no longer carries the always-empty
identity_overrides, orentity_selectoron non-Dynatrace integrations, as the compressed one already didn't. Every other document, including the SDK environment document, is unchanged.How did you test this code?
Compared every Dynamo document and the SDK environment document before and after, for an environment with segments, multivariate values, integrations, traits and overrides.