Conversation
An identity is only ever served one variant, and the dashboard only ever writes one at 100%, or none for the control value. The API now accepts nothing else.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stack/4-environment-flags #8605 +/- ##
=============================================================
- Coverage 98.82% 98.81% -0.01%
=============================================================
Files 1645 1645
Lines 67561 67591 +30
=============================================================
+ Hits 66764 66789 +25
- Misses 797 802 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-16 — run #20882 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20882 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20882 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #20882 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #8597
In this PR, we reject identity override writes, in Core and Edge, unless they pin a single variant at 100% or none for the control value.
This is a breaking change for API clients writing multivariate splits to identity overrides. The dashboard never does.
Existing identity overrides storing a split are left as they are, pending scoping of their migration.
How did you test this code?
Added tests for creating and updating a Core identity override, and creating an Edge one, with no variants, a pinned variant, a split, and a partial variant.