Skip to content

fix(gunicorn): support GUNICORN_KEEP_ALIVE setting in Procfile and Dockerfile - #8556

Open
siddiqueirshad wants to merge 1 commit into
Flagsmith:mainfrom
siddiqueirshad:fix/gunicorn-keep-alive-setting
Open

siddiqueirshad wants to merge 1 commit into
Flagsmith:mainfrom
siddiqueirshad:fix/gunicorn-keep-alive-setting

Conversation

@siddiqueirshad

Copy link
Copy Markdown

Fixes #8543. Enables GUNICORN_KEEP_ALIVE environment variable in �pi/Procfile and Dockerfile to configure HTTP keep-alive timeout.

@siddiqueirshad
siddiqueirshad requested review from a team as code owners September 18, 2026 14:39
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

@siddiqueirshad is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the api Issue related to the REST API label Sep 18, 2026
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8c04cc6f-dbce-4890-be8b-34fc59f8f9f4

📥 Commits

Reviewing files that changed from the base of the PR and between 49d957a and 099ea7e.

📒 Files selected for processing (2)
  • Dockerfile
  • api/Procfile

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The api-runtime Docker stage now sets GUNICORN_KEEP_ALIVE to 2. The web process passes this value to Gunicorn through --keep-alive, and uses 2 seconds when the variable is unset.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 099ea

No actionable merge-blocking risk is established; the default behavior remains consistent.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewelwell

matthewelwell commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Hi @siddiqueirshad , thanks for the contribution, but this doesn't resolve #8543. This merely resolves it when the Procfile is used (for Heroku-like deployments). You'll need to take a look at the Flagsmith/flagsmith-common repository in order to fully resolve the issue.

@siddiqueirshad

Copy link
Copy Markdown
Author

Hi @khvn26, when you get a chance, could you please take a look at this PR? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot change gunicorn keep-alive setting via GUNICORN_KEEP_ALIVE

2 participants