Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
========================================
Coverage 98.80% 98.81%
========================================
Files 1631 1637 +6
Lines 66920 67117 +197
========================================
+ Hits 66123 66320 +197
Misses 797 797 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
feature
Core API resolved override precedence and multivariate bucketing itself, in parallel with the engine it already used for segment matching. This routes identity flag evaluation through `get_evaluation_result` instead, leaving Core API responsible only for building an `EvaluationContext`. `Identity.get_all_feature_states` now asks the engine which override won rather than comparing feature states with `>`. It still returns Django rows: `FlagResult.metadata.feature_state_id` maps the engine's verdict back to the row it came from, so callers are unaffected for now. Identity overrides reach the engine the way SDKs express them, as a synthetic segment whose overrides sit at `priority = -inf`. That encodes "no segment override outranks an identity override", which until now was `FeatureState.__gt__` returning True unconditionally. Every segment with an override in the environment is now evaluated, rather than pre-filtering to segments the identity is known to match. A single pass is what lets a segment condition depend on a flag that is itself only resolved during evaluation (#1674). Contributes to #6654.
Drop the redundant OR term on the transient path, and the module docstring, comments and pragmas that restated what the code says.
…ypes `evaluation.py` mixed a mapper, a service and two result types. Split it along the lines the rest of the package already uses, and rename `build_identity_evaluation_context` to `map_identity_to_evaluation_context` to match the mapper naming convention. Tests follow the split. No behaviour change.
khvn26
force-pushed
the
feat/engine-evaluation-authority
branch
from
September 22, 2026 10:15
02251d0 to
e7192f5
Compare
github-actions
Bot
added
feature
…n_context The caller had to query feature states and hand them back in four mutually-consistent arguments. Resolve them in the mapper instead, as `map_environment_to_engine` alongside it already does, leaving one argument per genuine caller choice. `environments.identities.mappers` had nothing left to do and is gone; `evaluate_identity` calls the engine mapper directly. Feature states are now always resolved, so `Identity.get_segments` costs one more query. That is the price of correctness once segment conditions can read `$.flags.*`: a segments-only context cannot answer them.
khvn26
force-pushed
the
feat/engine-evaluation-authority
branch
from
September 22, 2026 11:06
6910685 to
6ac930f
Compare
github-actions
Bot
added
feature
Serialisers and integrations re-resolved a feature state's value per identity, hashing multivariate allocation themselves, after the engine had already decided it. Carry the engine's `FlagResult` on each feature state `Identity.get_all_feature_states` returns, so the value and variant travel with the row they came from. Removes `FeatureState.get_multivariate_feature_state_value` and `get_feature_state_value_by_hash_key`, and the `identity` argument to `get_feature_state_value`, which now means only "this state's stored value". `evaluated_value` is the value as evaluated, falling back to the stored one where nothing evaluated it. Edge identities keep their overrides in DynamoDB, so the rows the edge serialiser reads never pass through an evaluation. Those resolve through `features.evaluation.evaluate_feature_state` instead, which asks the engine about a single feature state.
github-actions
Bot
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6654
In this PR, we route identity flag evaluation through
get_evaluation_result, leaving Core API responsible only for building anEvaluationContext.How did you test this code?
Added
api/tests/unit/environments/identities/test_unit_identities_evaluation.py, and fixed existing test.