Skip to content

ci: scope uv-lock pre-commit hooks to their project directories - #8534

Merged
matthewelwell merged 2 commits into
mainfrom
ci/scope-uv-lock-hooks
Sep 22, 2026
Merged

ci: scope uv-lock pre-commit hooks to their project directories#8534
matthewelwell merged 2 commits into
mainfrom
ci/scope-uv-lock-hooks

Conversation

@matthewelwell

@matthewelwell matthewelwell commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add correct directory scoping to api|mcp-lockcheck hooks in pre-commit.

The uv-lock hook published by astral-sh/uv-pre-commit anchors files at the repository root,
assuming the project sits there:

files: ^(uv\.lock|pyproject\.toml|uv\.toml)$

Ours are at api/uv.lock and mcp/uv.lock, so neither instance matches anything — both report
(no files to check) Skipped on every run, locally and in CI.

Before

Link: https://results.pre-commit.ci/run/github/136163130/1789563046.t0oTcPlPT7u8Q1_SGJWinw

image
After

Link: (see workflows on this PR)

image

@matthewelwell @claude
ci: scope uv-lock pre-commit hooks to their project directories
82abb20 
The uv-lock hook published by astral-sh/uv-pre-commit anchors `files` at the
repository root, assuming the project sits there. Ours are in subdirectories, so
neither `api-lockcheck` nor `mcp-lockcheck` has ever matched a file — both report
"(no files to check) Skipped" in every run, including CI. The result is that we
have no lockfile validation at all.

Overriding `files` per hook scopes each to the project it checks. Both now execute
and pass under `make lint`, and fail on a stale lockfile rather than skipping.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
docs Ignored Ignored Preview Sep 15, 2026 3:38pm UTC
flagsmith-frontend-preview Ignored Ignored Preview Sep 15, 2026 3:38pm UTC
flagsmith-frontend-staging Ignored Ignored Preview Sep 15, 2026 3:38pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 38bd4998-187f-4903-8b45-9b25837ddbec

📥 Commits

Reviewing files that changed from the base of the PR and between fb60f42 and 958000e.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The mcp-lockcheck hook now declares the file pattern ^mcp/(uv\.lock|pyproject\.toml|uv\.toml)$. The hook therefore targets matching files under mcp/, consistent with the existing api-lockcheck configuration.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 95800

The MCP lockcheck now targets the intended project files, with no identified merge-blocking impact.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ci-cd Build, test and deployment related label Sep 15, 2026
matthewelwell
matthewelwell commented Sep 15, 2026
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Sep 15, 2026
@matthewelwell
matthewelwell marked this pull request as ready for review September 15, 2026 15:46
@matthewelwell
matthewelwell requested a review from a team as a code owner September 15, 2026 15:46
@matthewelwell
matthewelwell requested review from bakirFS and removed request for a team September 15, 2026 15:46
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8534 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8534 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-8534 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8534 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8534 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8534 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20469 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37 seconds
commit  958000e
info  🔄 Run: #20469 (attempt 1)

🗂️ Previous results
✅ oss · depot-ubuntu-latest-arm-16 — run #20469 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.5 seconds
commit  958000e
info  🔄 Run: #20469 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #20469 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  49.7 seconds
commit  958000e
info  🔄 Run: #20469 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #20469 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  3.6 seconds
commit  958000e
info  🔄 Run: #20469 (attempt 1)

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@matthewelwell
matthewelwell merged commit f345ed5 into main Sep 22, 2026
39 checks passed
@matthewelwell
matthewelwell deleted the ci/scope-uv-lock-hooks branch September 22, 2026 08:45
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Sep 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26 khvn26 khvn26 approved these changes
@bakirFS bakirFS Awaiting requested review from bakirFS bakirFS is a code owner automatically assigned from Flagsmith/flagsmith-engineering

Assignees

No one assigned

Labels

ci-cd Build, test and deployment related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewelwell @khvn26