Repository navigation
feat(Flag Dependency): Evaluate flags that depend on other flags in local evaluation - #70
matthewelwell wants to merge 0 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
86f3538c-fd98-4876-934a-8f967a33db37
⛔ Files ignored due to path filters: 1
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing: 4
Cargo.tomlsdk-spec/Cargo.tomltests/fixtures/mod.rstests/integration_test.rs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
| log = "0.4" | ||
| flume = "0.10.14" | ||
| flagsmith-flag-engine = "0.6" | ||
| flagsmith-flag-engine = { git = "https://github.com/Flagsmith/flagsmith-rust-flag-engine", rev = "6d892ee7cf44eb5860899e925aa2433de4356c2f" } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Replace the Git dependency before merge.
The release manifest must use flagsmith-flag-engine = "0.7" when engine 0.7.0 is available on crates.io. This Git revision is valid for interim validation but does not satisfy the stated release contract. Update this entry and the matching sdk-spec/Cargo.toml entry before merge.
|
Needs rebasing. |
3576b8e to
4bf93a4
Compare
Local evaluation ignores segment overrides that depend on another flag, so it disagrees with remote evaluation.
Closes SDK-8. Depends on Flagsmith/flagsmith-rust-flag-engine#42; merge once it's released as 0.7.0.
Changes
$.flags.<feature>.enablednever matched; they now apply to identity and environment flags.$.environment.name), as in the Java SDK.🤖 Generated with Claude Code