Conversation
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (35)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
/v2go install doesn't work as documented
Pull Request is not mergeable
Pull Request is not mergeable
`go install github.com/Flagsmith/flagsmith-cli@latest` resolves v1.1.0 — the npm-era tag, which contains no Go code — and fails with "does not contain package". Tagging v2 does not fix it: a module at major 2 or higher must carry the matching path suffix, and the +incompatible escape applies only to repos without a go.mod, so v2 tags would simply be invalid for the old path and @latest would stay on v1.1.0 forever. The suffix is unavoidable if we tag v2 at all; the alternatives were releasing the rewrite on the v1 line or dropping `go install` from the docs. The README pins the beta tag rather than using @latest, which skips prereleases when any release exists — v1.1.0 does. release-please keeps the pin current through extra-files, same as the two installers. `go install` names the binary after the module path, so it lands as flagsmith-cli; the README says so. beep boop
matthewelwell
left a comment
There was a problem hiding this comment.
Blindly stamping based on previous approval which was dismissed by a rebase 🙈
go install github.com/Flagsmith/flagsmith-cli@latestresolves v1.1.0 and fails. In go, major ≥2 requires the/v2suffix.module github.com/Flagsmith/flagsmith-cli/v2; imports rewritten, ldflags path updated@latestskips prereleases while v1.1.0 exists; release-please keeps the pin currentgo installnames binaries after the module path, so it lands asflagsmith-cliVerified: build, vet, test,
go mod tidy -diff, all hooks, and a goreleaser snapshot still stamping the version — a stale ldflags path would silently printdev.