Skip to content

Validate fixed-effect slope interactions and reduce latency - #282

Merged
eloualiche merged 3 commits into
FixedEffects:mainfrom
matthieugomez:fe-slope-validation
Aug 27, 2026
Merged

Validate fixed-effect slope interactions and reduce latency#282
eloualiche merged 3 commits into
FixedEffects:mainfrom
matthieugomez:fe-slope-validation

Conversation

@matthieugomez

@matthieugomez matthieugomez commented Aug 27, 2026

Copy link
Copy Markdown
Member
  • Reject transformed or non-numeric fe(...)&x slope columns with a clear error instead of silent misbehavior
  • Omit standalone RHS slopes already spanned by continuous-slope fixed effects
  • Skip fixed-effect parsing when no fixed effects are present and avoid invalidation-prone hvcat paths
  • Make deprecated method=:gpu calls fall back to CPU with an explicit message
  • Expand documentation, benchmarks, and regression coverage

@matthieugomez
matthieugomez force-pushed the fe-slope-validation branch 2 times, most recently from 5155876 to 646f9f4 Compare August 27, 2026 17:30
- Reject transformed or non-numeric fe(...)&x slope columns with a clear error
- Skip the fixed-effect parser on regressions without fe terms
- Avoid hvcat in basecol to reduce invalidations
- Add heterogeneous-slope lines to the benchmark
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@228f3eb). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage        ?   97.98%           
=======================================
  Files           ?        8           
  Lines           ?      793           
  Branches        ?        0           
=======================================
  Hits            ?      777           
  Misses          ?       16           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Omit RHS slopes spanned by continuous-slope fixed effects
- Fall back to CPU for the deprecated method=:gpu alias
- Expand documentation, benchmarks, and regression coverage
- Bump the package major version
- Document the coefficient-output breaking change
- Clarify how to load explicit GPU backends
@eloualiche
eloualiche merged commit 5edd010 into FixedEffects:main Aug 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants