Fix singleton pruning across fixed effects - #281
Merged
eloualiche merged 4 commits intoAug 27, 2026
Conversation
The previous repeated-scan loop could stop after a clean pass on the first fixed effect and miss singleton levels defined by a later fixed effect. That left observations in the sample when their singleton status came from the second or subsequent FE dimension. Replace repeated scans with a queue-based peel over FE group counts, using active-index xors to identify singleton observations without building reverse offsets. Add coverage for later-FE singletons, cascades, inactive rows, interaction FEs, duplicate singleton queue entries, and partial_out compatibility. Bump version to 1.13.3.
Solver iteration reporting can vary across dependency versions when the coefficients are already computed without an iterative solve. Keep the coefficient assertion and remove the exact x.iterations == 1 check.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage ? 97.81%
=======================================
Files ? 8
Lines ? 731
Branches ? 0
=======================================
Hits ? 715
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x.iterations == 1assertion whose value varies across dependency versions while the coefficient check remains stable1.13.3