Repository navigation
Fix mutants runner ignoring SIGTERM until the next trial - #2
Merged
Merged
Conversation
CI's first run failed on ubuntu in one test: SIGTERM sent to `npm run mutants` mid-trial was only handled after the NEXT mutant had run. The runner ran each trial's tests with spawnSync, which blocks the event loop, so the signal handler could not fire until later. Windows skips that test (no catchable signals), which is why it never failed locally. Trials now run their tests with an async spawn. A SIGINT or SIGTERM is handled at once: the runner kills the trial's tests, restores the mutated file and exits with 128 + the signal number. The SIGTERM test now expects exactly that (no half-finished row, lib/x.ts restored, the stub tests stopped). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's first run failed on ubuntu in one test: SIGTERM sent to
npm run mutantsmid-trial was only handled after the NEXT mutant had run. The runner ran each trial's tests with spawnSync, which blocks the event loop, so the signal handler could not fire until later. Windows skips that test (no catchable signals), which is why it never failed locally.Trials now run their tests with an async spawn. A SIGINT or SIGTERM is handled at once: the runner kills the trial's tests, restores the mutated file and exits with 128 + the signal number. The SIGTERM test now expects exactly that (no half-finished row, lib/x.ts restored, the stub tests stopped).