Fix issues with circle bounds - #1233
Open
Robotgiggle wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point in the 1.21 port the
CircleExecutionState.boundsvalue was changed from anAABBto aBlockBox. TheBlockBoxconstructor does not need the one-block adjustment that theAABBconstructor did in 1.20, so the presence of that adjustment was making the box one block too big.Also, likely as part of the change to using
BlockBox, the fold reflection patterns had been changed to return the actual corner positions of the bounds region, rather than the center of the corner blocks as in 1.20. This caused unexpected results when trying to use them to target blocks at the corners of the circle, since the game would have to determine which block to target given a position perfectly equidistant from 8 of them.This PR fixes both of those problems, and also updates the guidebook descriptions for the fold reflections to clarify that they return the center positions of the corner blocks, rather than the actual corner positions.