Skip to content

migramos addButton($viewName, [...]) a tab($viewName)->addButton([...]) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NeoRazorX merged 1 commit into from
Jun 29, 2026
Merged

migramos addButton($viewName, [...]) a tab($viewName)->addButton([...]) #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/FileUpdater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public static function upgradePhpFiles(): void
strpos($fileStr, 'FacturaScripts\Core\Model\Base') === false &&
strpos($fileStr, 'function clear()') === false &&
strpos($fileStr, 'DataBaseWhere') === false &&
strpos($fileStr, '$this->addButton(') === false &&
strpos($fileStr, '->addButton(') === false &&
strpos($fileStr, 'Core\Model\Base\JoinModel') === false
) {
continue;
Expand Down Expand Up @@ -442,6 +442,13 @@ public static function upgradePhpFiles(): void
// reemplazamos protected function onChange($field) por protected function onChange(string $field): bool
$fileStr = str_replace('protected function onChange($field)', 'protected function onChange(string $field): bool', $fileStr);

// migramos addButton($viewName, [...]) a tab($viewName)->addButton([...])
$fileStr = preg_replace(
'/\$this->addButton\(\s*([^,]+)\s*,\s*(\[[\s\S]*?\])\s*\);/m',
'$this->tab($1)->addButton($2);',
$fileStr
);

// manejamos el archivo Init.php específicamente
if (basename($pathFile) === 'Init.php') {
// añadimos tipo de retorno void a init() y update() si no existe
Expand Down