-
Notifications
You must be signed in to change notification settings - Fork 14
chore(runtime): harden node/browser compatibility and release 4.14.0 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4ce22ab
refactor: modernize runtime compatibility and remove legacy polyfills
javorosas 9aef4b9
refactor: use feature detection for runtime compatibility
javorosas c06c73a
docs: modernize README and align stream-like typings
javorosas 550c7b3
test: add runtime compatibility unit tests and ci workflow
javorosas a10f35f
test: split node/web runtime suites with vitest and type contracts
javorosas ff3814b
test: add playwright browser smoke tests to ci
javorosas ad0ef75
test: cover basic auth encoding paths for buffer and btoa
javorosas 4795a4b
refactor: use bearer authorization header by default
javorosas 67d684e
docs: document new test strategy and ci coverage in changelog
javorosas 26f2012
docs: add ci status badge to readme
javorosas 4798c6a
test: verify binary download stream pipe to node writable
javorosas ac99b6f
chore(release): bump version to 4.14.0
javorosas ae7ac51
docs(changelog): credit @tetexxr for rfc_provider_cert contribution
javorosas b8007ea
ci: avoid duplicate runs on PR branches
javorosas c9736e5
fix: address copilot review feedback for runtime robustness
javorosas 0437ebb
ci: narrow runtime matrix to avoid redundant web checks and node18 fa…
javorosas 348d02d
ci: restore node18 support with dist-based compatibility smoke
javorosas 26dbd82
docs(changelog): add explicit 4.14.0 bug-fix notes
javorosas 61b1603
test(ci): expand node18 runtime to include web-sim parity suite
javorosas 1550e0e
ci: add node 24 to node-runtime matrix
javorosas 8742a77
ci: run web-runtime only on node24 and remove node18 web compat suite
javorosas 0eea22f
ci: align node18 job display name with node-runtime matrix
javorosas 1ef8562
fix: read error response body once before json fallback parsing
javorosas ecc3a19
test: add non-ok response regression coverage for wrapper errors
javorosas e1fd5f2
test: add error-path and query serialization hardening coverage
javorosas 2fe7830
chore(deps): upgrade tooling to latest majors and fix ts6 compatibility
javorosas 3967846
chore(lint): migrate from semistandard to eslint+prettier modern stack
javorosas 3b58a85
fix(ci): regenerate lockfile for npm 10 compatibility
javorosas 4ccf1ca
chore: harden publish artifacts and pin npm in CI
javorosas 86d8ca6
chore: address remaining copilot review suggestions
javorosas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build-dist: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
|
|
||
| - name: Pin npm version | ||
| run: npm i -g npm@10.9.2 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build package | ||
| run: npm run build | ||
|
|
||
| - name: Upload dist artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: dist-artifact | ||
| path: dist | ||
| if-no-files-found: error | ||
|
|
||
| node18-runtime: | ||
| name: node-runtime (18) | ||
| runs-on: ubuntu-latest | ||
| needs: build-dist | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
|
|
||
| - name: Download dist artifact | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: dist-artifact | ||
| path: dist | ||
|
|
||
| - name: Run Node 18 runtime compatibility smoke | ||
| run: node --test test/compat/node18-compat.test.cjs | ||
|
|
||
| node-runtime: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [20, 22, 24] | ||
|
|
||
|
javorosas marked this conversation as resolved.
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: npm | ||
|
|
||
| - name: Pin npm version | ||
| run: npm i -g npm@10.9.2 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Node runtime tests | ||
| run: npm run test:node | ||
|
|
||
| web-runtime: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [24] | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: npm | ||
|
|
||
| - name: Pin npm version | ||
| run: npm i -g npm@10.9.2 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run web-simulated runtime tests | ||
| run: npm run test:web | ||
|
|
||
| build-and-types: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
|
|
||
| - name: Pin npm version | ||
| run: npm i -g npm@10.9.2 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build package | ||
| run: npm run build | ||
|
|
||
| - name: Run type contract tests | ||
| run: npm run test:types | ||
|
|
||
| browser-smoke: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
|
|
||
| - name: Pin npm version | ||
| run: npm i -g npm@10.9.2 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Install Playwright browser | ||
| run: npx playwright install --with-deps chromium | ||
|
|
||
| - name: Run browser smoke tests | ||
| run: npm run test:browser | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| "singleQuote": true | ||
| "singleQuote": true, | ||
| "semi": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) FacturAPI | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.