Pin fog-plugins v1.6.17 - #1365
Merged
Merged
Conversation
Carries the plugin half of ADR 0028: the ten two-state columns in
LDAPServers, OIDCProviders and location become tinyint(1), converted
through Schema::enumToTinyint() -- which this branch already ships, so
the ordering is right.
Without the bump the core columns are tinyint and the plugin ones stay
enum('0','1'), which is the two-conventions state ADR 0028 exists to end.
FOGProject/fog-plugins#27, released as v1.6.17.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the plugin half of ADR 0028 — the ten two-state columns in
LDAPServers,OIDCProvidersandlocationbecometinyint(1).They convert through
Schema::enumToTinyint(), which #1364 already landed onthis branch, so the ordering is right: the helper exists before anything calls
it.
Without this bump the core columns are
tinyint(1)and the plugin ones stayenum('0','1')— the two-conventions state ADR 0028 exists to end, and theplugin columns keep the index trap.
Verified against a restore of a live 1.6 database, driving each plugin manager's
own
install(): all ten converted, every value, default and nullabilitypreserved, idempotent on re-run.
FOGProject/fog-plugins#27, released as v1.6.17.