Bump FOG_PLUGINS_VERSION to v1.6.14 - #1277
Merged
Merged
Conversation
Picks up FOGProject/fog-plugins#24: wolbroadcast adopts the non-destructive schema() contract. It was the last plugin still building its table from install() directly, and install() called uninstall() first -- which is a DROP. Plugin::installdb() falls back to calling install() when a manager has no schema(), and wolbroadcast had none, so that drop ran on every install and took the user's broadcast addresses with it. Step 0 is now a CREATE TABLE IF NOT EXISTS, so on an existing install the change is a no-op that records pSchema = 1. It also closes the last verification gap in the GH-1245 plugin work: with createSql() public the probe can call it, so the live check covers 24 tables rather than 23. No core change needed -- the seam these plugins call landed in #1275. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up FOGProject/fog-plugins#24 (released as v1.6.14): wolbroadcast adopts the non-destructive
schema()contract.It was the last plugin still building its table from
install()directly, andinstall()calleduninstall()first — which is a DROP.Plugin::installdb()falls back to callinginstall()when a manager has noschema(), and wolbroadcast had none, so that drop ran on every install and took the user's broadcast addresses with it.Step 0 is now a
CREATE TABLE IF NOT EXISTS, so on an existing install the change is a no-op that recordspSchema = 1. Nothing is dropped and no data moves.It also closes the last verification gap in the GH-1245 plugin work: with
createSql()public the probe can call it, so the live check covers 24 tables rather than 23 — all accepted, 61 columns carrying a default.No core change needed — the seam these plugins call landed in #1275.
🤖 Generated with Claude Code