Make a FOS failure visible: a Failed task state, and a tab that shows the task log

[mastacontrola]

Follow-up to #1207 / #1208. FOS reports an error, FOG records it — and then nothing about the system changed: the task stayed where it was, and the row it wrote landed in a table nothing has ever displayed.

Two commits, one job: make a FOS failure something you can see.

1. A Failed task state (schema 339)

A task the host died on stayed Queued or In-Progress forever. Host::loadTask() and Host::getActiveTaskCount() count those states as live, so the host could not be re-tasked until somebody noticed and cancelled the task by hand.

• taskStates row 6, Failed — "Host reported that the task could not be completed."
• TaskState::getFailedState(), with a FAILED_STATE hook like every other state getter, plus the FOGBase passthrough its five siblings already have
• TaskError moves the task to it on an error. A warning never does — a warning means FOS carried on.

Not Cancelled, which was the alternative: Cancelled means an administrator stopped it, and losing the difference between "somebody stopped this" and "this broke" costs the operator the one fact they open the task list to find.

Adding a sixth state is additive because every "is this task live" test in the tree is an allowlist — getQueuedStates() plus getProgressState() — so a state nobody listed is inactive by construction. Complete and Cancelled rows already persist in tasks (20 and 33 of them on the reference install), so a Failed row lingering is existing behavior, not new litter.

The state is written for every task type, not just imaging ones — a Memtest the host died on is as finished as a deploy. Only HOST_IMAGE_FAIL stays imaging-specific. _markFailed() is guarded on the taskStates row existing, so a web tree updated ahead of its database leaves the task alone rather than pointing it at a state that is not there. Apart from stateID the endpoint writes nothing about the task — it is unauthenticated, matched by MAC like every FOS endpoint, so what it may change stays a list of one.

Recent pane: the state would otherwise be invisible — not active, and Recent asked for Complete and Cancelled only. Its filter becomes All / Complete / Cancelled / Failed with Failed in the default. (both → all, since a two-way label was about to start lying; the endpoint still reads any unrecognised value as all-of-them.)

2. A tab that shows the task log

taskLog has been written since 1.2 and displayed never. Schema 338 started putting FOS report text in the same table, so the message a machine sends when a deploy dies was being stored and shown to nobody.

New Logs tab on Task Management: time, host, task type, state at the time, entry type, message, recorded by. Errors and warnings are badged, because the type is what tells you whether the machine stopped or carried on. Defaults to reports — state rows outnumber them several-fold and would bury the thing the tab exists to surface — with All / Errors / Warnings / State changes one click away.

Read through a derived table: taskLog and tasks both carry taskID and taskStateID, and complex() builds its select list as bare backticked names, so an unqualified name across that join is ambiguous and the query dies. Aliasing inside the subquery gives every column a name of its own; MariaDB merges a derived table with no aggregate in it.

FOG_BCACHE_VER bumped — fog.task.list.js changed.

Verification

Against an isolated copy of this server's database (podman MariaDB on :13306, shadow web tree, throwaway host on a locally-administered MAC — nothing live was touched):

case	result
error on a deploy task	state → 6, getActiveTaskCount() → 0, loadTask() invalid
error on a wipe task (non-imaging)	state → 6
warning	state stays Queued, taskLog row typed warning
every endpoint path, unknown MAC included	identical ## body
step 339 run twice	converges, taskStates still 6 rows
Recent pane's own WHERE	54 rows where the old one returned 53
getTaskLogs() through complex()	correct row shape, joins resolving host name and both icons
each log filter's WHERE	2 reports / 1 error / 1 warning / 52 state / 54 all

Ten new assertions across tests/task-error-report.test.php and the new tests/task-log-view.test.php, every one mutation-tested. Full suite green (56 files).

Downstream

None — no route classes added or removed.