Ship plugins v1.6.10 - #1179
Merged
Merged
Conversation
Fixes where a successful OIDC single logout lands (fog-plugins#20). With single logout and forced redirect both enabled, signing out left the person on management/login.php -- the break-glass page this branch added in #1175 -- rather than on FOG's ordinary login page. Single logout is exactly the case where the provider session has been ended, so returning to the redirecting page is right: the provider is then asked again and prompts, which is how you sign out and sign back in as somebody else. Admins who enabled single logout on v1.6.9 must re-register the post-logout redirect URI at their provider; it changes from .../management/login.php to .../management/index.php. FOG prints the current value on the provider page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes where a successful OIDC single logout lands
(fog-plugins#20).
With single logout and forced redirect both enabled, signing out left the person
on
management/login.php— the break-glass page this branch added in #1175 —rather than on FOG's ordinary login page. Single logout is exactly the case where
the provider session has been ended, so returning to the redirecting page is
right: the provider is asked again and prompts, which is how you sign out and
sign back in as somebody else.
Reported from a live install after #1177 shipped v1.6.9.
redirect URI at their provider — it changes from
…/management/login.phpto…/management/index.php. FOG prints the current value on the provider page.sh tests/run-all.sh→ 59 passed, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR