Install efitools only on a branch that has the Secure Boot test - #22
Merged
Conversation
This workflow is shared by every fogproject branch, but only the 1.6 line carries tests/secureboot-authvars.test.sh. On dev-branch the apt install bought nothing -- and it is not free. It is the flakiest step in the job: a transient apt failure or a slow mirror wedges it for twenty minutes and takes the whole run with it, which is how a dev-branch pull request whose suite passed in 24 seconds came to need a manual cancel and rerun (fogproject#1170). Same shape as the composer probe added in #19, and for the same reason: decide from the tree rather than the branch name, because the branch that has the test is a thing that will change and the presence of the file is the actual precondition. The step summary says why it was skipped, so a missing efitools reads as a deliberate skip rather than as something that quietly did not happen. The 1.6 side is unchanged -- the file is there, the probe is true, and the install runs exactly as before. secureboot-authvars.test.sh still skips itself when efitools is absent and run-all.sh still counts that as a pass, so this does not weaken enforcement anywhere it existed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow is shared by every
fogprojectbranch, but only the 1.6 line carriestests/secureboot-authvars.test.sh. Ondev-branchtheInstall efitoolsstep buys nothing at all — and it is not free.It is the flakiest step in the job. A transient apt failure or a slow mirror wedges it for twenty minutes and takes the whole run with it. That is how fogproject#1170 — whose suite actually runs in 24 seconds — came to need a manual cancel and rerun:
The fix
A probe step, same shape as the composer probe added in #19 and for the same reason:
Decided from the tree, not the branch name — the branch that has the test is a thing that will change, and the presence of the file is the actual precondition. The step summary says why it was skipped, so a missing efitools reads as a deliberate skip rather than as something that quietly did not happen.
What does not change
The 1.6 side is untouched: the file is there, the probe is true, the install runs exactly as before.
secureboot-authvars.test.shstill skips itself when efitools is absent andrun-all.shstill counts that as a pass — so this does not weaken enforcement anywhere it existed.