<CI>(workflow): Codecov BASE-on-push + fix macOS openssl / bump Ubuntu runner#960
Open
kyonRay wants to merge 2 commits into
Open
<CI>(workflow): Codecov BASE-on-push + fix macOS openssl / bump Ubuntu runner#960kyonRay wants to merge 2 commits into
kyonRay wants to merge 2 commits into
Conversation
Codecov could not show a coverage delta on PRs because the base branch never had a coverage report: the workflow only ran on pull_request/release, so merges (which are pushes) never uploaded coverage for the base commit (hence the 'missing base commit' warning and the empty +/- column). Add a push trigger for master and release-* and gate the heavy integration 'build' job to non-push events, so a push to a main branch runs only the lightweight 'coverage' job and uploads a BASE report. PR/release behavior is unchanged. After this lands, future PRs show a proper coverage delta.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-3.9.0 #960 +/- ##
================================================
Coverage ? 52.08%
Complexity ? 4040
================================================
Files ? 430
Lines ? 17592
Branches ? 1962
================================================
Hits ? 9163
Misses ? 7699
Partials ? 730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The macOS build hard-failed at the dependency step: Homebrew removed the
openssl@1.1 formula ('No available formula with the name openssl@1.1'), so
'brew install openssl@1.1' exits 1. Switch to openssl@3 — the SDK native runs
fine against OpenSSL 3.x (the Ubuntu job already executes the full integration
suite with libssl 3.x). Also bump the Ubuntu runner from ubuntu-22.04 to
ubuntu-latest (build matrix + coverage job).
Note: the remaining Ubuntu integration failures are pre-existing flaky tests
(node/chain state, e.g. -4008 / 'Call address error'), unrelated to the runner
version; the build job is continue-on-error so it does not block merge.
|
kyonRay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CI/workflow maintenance, two parts:
1. Codecov BASE report on push
Codecov warned
Please upload report for BASE (...)and left the+/-column empty on PRs. Root cause: the workflow only ran onpull_request/release, so merges (which are pushes) never uploaded coverage for the base commit. Add apushtrigger formaster/release-*and gate the heavy integrationbuildjob to non-push events, so a push runs only the lightweightcoveragejob and produces a BASE report. After this lands, future PRs show a proper coverage delta.2. Fix broken runners
openssl@1.1formula, sobrew install openssl@1.1exits 1 (No available formula with the name "openssl@1.1"). Switch toopenssl@3— the SDK native works on OpenSSL 3.x (the Ubuntu job already runs the full integration suite with libssl 3.x).ubuntu-22.04→ubuntu-latest(build matrix + coverage job).No source code changes.
🤖 Generated with Claude Code