Expose AssembleEIP1559TransactionService constructor to SDK consumers#957
Open
Copilot wants to merge 4 commits into
Open
Expose AssembleEIP1559TransactionService constructor to SDK consumers#957Copilot wants to merge 4 commits into
AssembleEIP1559TransactionService constructor to SDK consumers#957Copilot wants to merge 4 commits into
Conversation
* Initial plan * Remove fisco-bcos.org URL, replace with GitHub repo URL in build.gradle Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AssembleEIP1559TransactionService constructor accessibility
Expose Jun 16, 2026
AssembleEIP1559TransactionService constructor to SDK consumers
kyonRay
approved these changes
Jun 17, 2026
There was a problem hiding this comment.
Pull request overview
Exposes AssembleEIP1559TransactionService as a truly usable public API by making its Client constructor public, and adds a regression test to ensure SDK consumers can instantiate the service from outside the transactionv1 package.
Changes:
- Make
AssembleEIP1559TransactionService(Client client)public. - Add a unit test in a different package to verify external instantiation works.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/fisco/bcos/sdk/v3/transaction/manager/transactionv1/AssembleEIP1559TransactionService.java | Makes the service constructible by external consumers by changing constructor visibility to public. |
| src/test/java/org/fisco/bcos/sdk/v3/test/transaction/manager/AssembleEIP1559TransactionServiceTest.java | Adds a cross-package unit test to prevent regressions in the intended public API surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+12
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import org.fisco.bcos.sdk.v3.client.Client; | ||
| import org.fisco.bcos.sdk.v3.crypto.CryptoSuite; | ||
| import org.fisco.bcos.sdk.v3.model.CryptoType; | ||
| import org.fisco.bcos.sdk.v3.transaction.manager.transactionv1.AssembleEIP1559TransactionService; | ||
| import org.fisco.bcos.sdk.v3.transaction.manager.transactionv1.AssembleTransactionService; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; |
…tion-service-constructo
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssembleEIP1559TransactionServicewas public but not constructible outsidetransactionv1because its only constructor had package-private visibility. As a result, the EIP-1559 transaction assembly API was unreachable to external SDK users despite exposing public send/deploy methods.API accessibility
AssembleEIP1559TransactionService(Client client)from package-private topublic.AssembleTransactionService, which is already directly instantiable by consumers.Regression coverage
org.fisco.bcos.sdk.v3.transaction.manager.transactionv1.Consumer impact
sendEIP1559Transaction(...)deployContractEIP1559(...)