Make SDK and EventSubscribe shutdown idempotent#956
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix JVM SIGSEGV in native bcos_sdk_stop when stopping SDK
Make SDK and EventSubscribe shutdown idempotent
Jun 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Stopping or destroying
Client/EventSubscribecould re-enter native shutdown on the same JNI-backed handle and crash the JVM inbcos_sdk_stop. This change tightens Java-side lifecycle handling so repeated shutdown paths do not double-stop or tear down shared native state out of order.Client lifecycle hardening
ClientImpl.start(),stop(), anddestroy()synchronized and stateful.stop()/destroy()calls after the first effective shutdown.RpcJniObj.stop()/BcosSDKJniObj.destroy(...)on the same client handle.Event subscription ownership model
EventSubscribe.build(group, config)→ owns the internally created clientEventSubscribe.build(client)→ borrows the caller-provided clientEventSubscribeinstance owns it.Safer EventSubscribe shutdown
EventSubscribeImp.stop()/destroy()idempotent.Focused regression coverage
ClientImpl.stop()/destroy().EventSubscribeshutdown behavior.Example of the intended behavior: