Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ publishing {
pom {
name = 'fisco-bcos'
description = 'fisco-bcos java-sdk'
url = 'http://www.fisco-bcos.org'
url = 'https://github.com/FISCO-BCOS/java-sdk'

licenses {
license {
Expand Down
10 changes: 9 additions & 1 deletion src/main/java/org/fisco/bcos/sdk/v3/codec/ContractCodec.java
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,15 @@ public List<Object> decodeConstructorInput(String abi, String bin, String input)

ContractABIDefinition contractABIDefinition = this.abiDefinitionFactory.loadABI(abi);
ABIDefinition abiDefinition = contractABIDefinition.getConstructor();
return this.decodeMethodAndGetInputObject(abiDefinition, paramsInput).getLeft();
ABIObject inputObject = ABIObjectFactory.createInputObject(abiDefinition);
try {
return ContractCodecTools.decodeJavaObject(inputObject, paramsInput, isWasm);
} catch (Exception e) {
logger.error(" exception in decodeConstructorInput : {}", e.getMessage());
}
String errorMsg = " cannot decode in decodeConstructorInput with appropriate interface ABI";
logger.error(errorMsg);
throw new ContractCodecException(errorMsg);
Comment on lines +684 to +691
}

public List<String> decodeConstructorInputToString(String abi, String bin, String input)
Expand Down
25 changes: 25 additions & 0 deletions src/test/java/org/fisco/bcos/sdk/v3/test/codec/ABICodecTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,31 @@ public void testEncodeConstructor() {
}
}

@Test
public void testDecodeConstructorInputWithParams() {
String constructorAbi =
"[{\"inputs\":[{\"internalType\":\"uint256\",\"name\":\"a\",\"type\":\"uint256\"},{\"internalType\":\"string\",\"name\":\"b\",\"type\":\"string\"}],\"stateMutability\":\"nonpayable\",\"type\":\"constructor\"}]";
List<String> args = new ArrayList<String>();
args.add("4660");
args.add("hello constructor");
ContractCodec abiCodec = new ContractCodec(TestUtils.getCryptoSuite(), false);
try {
byte[] constructorEncode =
abiCodec.encodeConstructorFromString(constructorAbi, "0xaaaaaaaa", args);
String input = "0x" + Hex.toHexString(constructorEncode);
List<Object> decoded =
abiCodec.decodeConstructorInput(constructorAbi, "0xaaaaaaaa", input);
List<String> decodedString =
abiCodec.decodeConstructorInputToString(constructorAbi, "0xaaaaaaaa", input);
Assert.assertEquals(args.size(), decoded.size());
Assert.assertEquals(new BigInteger(args.get(0)), decoded.get(0));
Assert.assertEquals(args.get(1), decoded.get(1));
Assert.assertEquals(args, decodedString);
} catch (Exception e) {
Assert.fail(e.getMessage());
}
}

@Test
public void testEncodeConstructorWithInvalidParams() {
List<String> args = new ArrayList<String>();
Expand Down
Loading