Check for netstandard when choosing a system mono version and allow the user to set the mono path#34
Open
thearst3rd wants to merge 2 commits into
Open
Check for netstandard when choosing a system mono version and allow the user to set the mono path#34thearst3rd wants to merge 2 commits into
thearst3rd wants to merge 2 commits into
Conversation
Contributor
|
I can confirm that the installer didn't work on Fedora 44 before this patch. After applying it, it started working. In Arch Linux, everything seems to be working as before; no regressions have been observed here. |
Contributor
|
In case there are situations involving non-standard Mono installations (after all, this is Linux, anything is possible here), I think it would be a good idea to let users specify the installation directory for Mono using an installer argument. |
Member
Author
|
Added in b082bee |
thearst3rd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Might still be worth considering the other options in the issue (especially allowing the user to override the
monoPath)