This repository was archived by the owner on Aug 26, 2026. It is now read-only.
chore: gitignore the GitHub App private key temp file - #767
Merged
Conversation
app-pk.tmp holds the GitHub App private key, pasted out of the App settings page during the Flux source cutover. It sat untracked and unignored in the repository root, one `git add .` away from being committed. The credentials block above it already covers *.pem, *.key, *.p12 and *.pfx, but the file carries a .tmp extension so none of those patterns matched it. History was checked before removing the local copy: no commit touches that path and no object in any ref contains the key body, so the key was never exposed and needs no rotation. The live copy is the githubAppPrivateKey entry in the flux-system Secret, which is what Flux authenticates with -- verified by comparing SHA-256 of both, 1679 bytes and identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app-pk.tmpholds the GitHub App private key, pasted out of the App settings page during the Flux source cutover. It was sitting untracked and unignored in the repository root — onegit add .from being committed.The credentials block in
.gitignorealready covers*.pem,*.key,*.p12and*.pfx. The.tmpextension meant none of them matched.Checked before deleting the local copy
Never exposed. No commit touches that path, and searching every object in every ref for the key body returns nothing:
So no rotation is needed.
Not the only copy. The key lives in the
githubAppPrivateKeyentry of theflux-systemSecret, which is what Flux authenticates to GitHub with. Confirmed by fingerprint rather than by reading either value:Identical, so deleting the working copy loses nothing.
Note
That cluster Secret is now the only copy. A GitHub App private key cannot be re-downloaded, so if it is ever lost the recovery is to generate a new one in the App settings and update the Secret — not a problem, just worth knowing.
app-id.tmpis left in place and unignored deliberately: an App ID is not a secret.