Repository navigation
ci(board): add Changes requested status to the board sweep - #925
Open
navareamol wants to merge 1 commit into
Open
navareamol wants to merge 1 commit into
navareamol wants to merge 1 commit into
Conversation
A ready PR whose reviewer asked for changes used to go back to In Progress, next to drafts. The board could not show which PRs were waiting on their author after a review. The sweep now moves such a PR to a new Changes requested status. It sits between In Progress and Needs review. When the author asks every blocking reviewer to look again, the PR moves to Needs review as before. Drafts stay In Progress. Issues follow their furthest linked PR, so an issue whose only PR has changes requested shows Changes requested. Tests: 59 pass, 8 of them new or changed. 8 fail against the old code. The privacy test checks the new status name never reaches the public log.
navareamol
requested review from
LeeroyHannigan,
amrith,
c33howard,
eliseong,
hitesh96db,
jcshepherd,
pdf-amzn and
robinnsc
as code owners
November 10, 2026 04:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a reviewer asks for changes, the PR card goes back to In Progress. It then looks the same as a draft. The board cannot show which PRs are waiting on their author after a review.
Workflow
Columns, in order: Todo -> In Progress -> Changes requested -> Needs review -> Review -> Done
Issues still take the furthest status of their trusted linked PRs.
Use cases
Negative and edge cases
Before merge
Add a
Changes requestedoption to the board's Status field, between In Progress and Needs review. Use the website, not the API. The API rewrites all options.Tests
59 pass (8 new or changed). Run against the old code, 8 fail, so they check the new rule.