Repository navigation
fix: close the Apple Wallet sheet when the issuer call fails - #132
Merged
JakubKorytko merged 5 commits intoOct 29, 2026
Merged
JakubKorytko merged 5 commits into
JakubKorytko merged 5 commits into
Conversation
A thrown encrypt callback used to leave the Add Payment Pass sheet waiting for a payload that would never arrive.
This was referenced Oct 27, 2026
Contributor
Author
This was referenced Oct 27, 2026
Contributor
Author
|
@JakubKorytko for a look when you have a minute. Requesting a review from the fork returns a permissions error, so this comment is the ping. |
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
one wording fix below + conflicts
Contributor
Author
|
@JakubKorytko merged current |
Member
|
conflicts with main, and may you address #91 (comment) here? |
deviceType is only set on the completed response, so the other branch never has it.
Contributor
Author
|
@JakubKorytko merged current |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
If
addCardToAppleWallet's issuer callback throws, the Add Payment Pass sheet used to stay open. PassKit was still waiting for a payload, and there was no way to close it.IOSFailAddPaymentPassdismisses the sheet and drops the PassKit completion handler, because there is no payload to give it. It also clears the account id stored for the device lookup.addCardToAppleWalletcalls it when the callback throws, then rethrows that error. Closing the sheet is best-effort: the issuer error is what the caller sees.Android resolves the native method and does nothing. The public function still throws on Android, as before.
Related Issues
No existing issue. This showed up while adding a card from an app that is on TestFlight.
Manual Tests
This repo has no automated tests. Typecheck and lint pass. The example app builds for the iOS simulator with the new architecture. Android was not compiled here: the example app does not include the TapAndPay SDK. The Kotlin change is a stub that resolves the promise.
addCardToAppleWalletand throw from the issuer callback. The sheet closes and the thrown error reaches the caller.Linked PRs
Merged current
main, which includes #91 and #96.IOSFailAddPaymentPassclears the account id that flow stores on the enrollment session. #133 and #134 also edit the spec, the README, orWalletManager.swift/RNWallet.mm. Whichever lands next will need a small merge.