fix(dx): address 0.12 onboarding review notes#91
Merged
Conversation
- site index.astro: update heroSnippet and quickstartSnippet from old draw(backend)/backend.clear()/node.render(backend) API (v0.8.x style) to current draw(context)/context.backend.clear()/context.render(node) - site index.astro quickstartSnippet: add explicit canvas config to Application constructor (consistent with all other examples) - README quickstart: add missing context.backend.clear() before render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 0.12 post-merge onboarding review found stale API snippets in user-facing onboarding surfaces.
site/src/pages/en/index.astrostill showed old v0.8.x-style snippets such asdraw(backend),backend.clear(), andnode.render(backend).The README quickstart snippet also missed
context.backend.clear().Solution
Update the onboarding snippets to the current rendering API:
draw(context)context.backend.clear()context.render(node)Scope
DX/docs snippet fix only. No engine, template, playground, or runtime changes.
Validation
pnpm typecheck— passed (0 errors)pnpm typecheck:guides— passed (32 extracted, 22 no-check, 217 partial)pnpm test— passed (139 test files, 1810 tests)pnpm site:build— passed (568 pages built, no errors)