Skip to content

feat(core): expose durable room-send options - #431

Merged
Mearman merged 1 commit into
ExaDev:mainfrom
ovidius72:fix/durable-room-send
Oct 19, 2026
Merged

Mearman merged 1 commit into
ExaDev:mainfrom
ovidius72:fix/durable-room-send

Conversation

@ovidius72

@ovidius72 ovidius72 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Why

Room sends already support durable: true internally, but the public SendRoomMessageOptions type omits it. Passing it through MeshStore or CommsStore therefore fails TypeScript checking.

Changes

  • Add durable to the shared SendRoomMessageOptions and export that type from the package entry point.
  • Use the shared options type directly in the room sender, removing the redundant internal type.
  • Describe what the option does in the API comment, including FileStore ignoring it because messages are already persisted.
  • Give durable room sends their own README section. State explicitly that room notices are only stored locally: nothing currently announces or fetches them, and automatic offline catch-up still needs policy and bridge wiring.
  • Add public-API integration cases for omitted, false and true values, including verification of the recorded signed notice.

Verification

  • All 1,885 tests across 212 files pass, along with lint and TypeScript checking.
  • The new public-API cases pass; the existing default send behaviour is preserved.

@Mearman Mearman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is right: durable reaches RoomMessaging.sendRoomMessage through MeshStore, and the test discriminates on all three values. The inline comments are small fixes to the doc comment, the leftover alias and the README wording. Since this adds public API, feat(core) fits better than fix(core), and squashing the three commits into one would help, since the third undoes the second.

Comment thread src/core/comms-store.ts Outdated
Comment thread src/core/room-messaging.ts Outdated
Comment thread README.md Outdated
@ovidius72
ovidius72 force-pushed the fix/durable-room-send branch from ac5a240 to ddf5114 Compare October 19, 2026 15:36
@ovidius72 ovidius72 changed the title fix(core): expose durable room-send options feat(core): expose durable room-send options Oct 19, 2026
@ovidius72
ovidius72 requested a review from Mearman October 19, 2026 15:42

@Mearman Mearman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three comments are addressed in ddf5114 and CI is green. Thanks.

@Mearman
Mearman merged commit 2f83f48 into ExaDev:main Oct 19, 2026
13 of 14 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants