Repository navigation
feat(core): expose durable room-send options - #431
Merged
Merged
Conversation
Mearman
requested changes
Oct 19, 2026
Mearman
left a comment
Member
There was a problem hiding this comment.
The change itself is right: durable reaches RoomMessaging.sendRoomMessage through MeshStore, and the test discriminates on all three values. The inline comments are small fixes to the doc comment, the leftover alias and the README wording. Since this adds public API, feat(core) fits better than fix(core), and squashing the three commits into one would help, since the third undoes the second.
ovidius72
force-pushed
the
fix/durable-room-send
branch
from
October 19, 2026 15:36
ac5a240 to
ddf5114
Compare
Contributor
|
🎉 This PR is included in version 8.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Room sends already support
durable: trueinternally, but the publicSendRoomMessageOptionstype omits it. Passing it throughMeshStoreorCommsStoretherefore fails TypeScript checking.Changes
durableto the sharedSendRoomMessageOptionsand export that type from the package entry point.Verification