Repository navigation
[pull] master from beyond-all-reason:master - #104
Merged
Merged
Conversation
* Add a per-vertex RGBA8 color to the models VBO SVertexData gets a normalized RGBA8 color (76 -> 80 bytes), bound at attribute 15 of the models VAO and mirrored as the `color` attribute of VBO:ModelsVBO(). It defaults to opaque white, the glTF meaning of an absent COLOR_0, and nothing fills it yet. Attribute 15 is the last one OpenGL guarantees; Lua VAOs built on the models VBO add their instance attributes from 6 upwards. * Load glTF COLOR_0 into the model vertex color The glTF parser reads COLOR_0 (VEC3 or VEC4, float or normalized integer) into the new vertex color, clamped to 0..1 and quantized to bytes; VEC3 gets opaque alpha. Models without it keep the white default. Engine.FeatureSupport.modelVertexColor tells Lua the color is available. * Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )