Add trigger to call Level.TeleportTo() - #1146
Open
grog398 wants to merge 5 commits into
Open
Conversation
maddie480-bot
added
the
1: review needed
microlith57
reviewed
Jul 19, 2026
Co-authored-by: microlith57 <microlith57@gmail.com>
Co-authored-by: microlith57 <microlith57@gmail.com>
# Conflicts: # Celeste.Mod.mm/Mod/Entities/TeleportTrigger.cs
Wartori54
requested changes
Aug 1, 2026
|
|
||
| _nextLevel = data.Attr("nextLevel"); | ||
| _introType = data.Enum("introType", Player.IntroTypes.None); | ||
| _useWorldCoordinates = data.Bool("useWorldCoordinates"); |
Member
There was a problem hiding this comment.
Does it make sense to ever use world coordinates? I feel like using world coords is just more cumbersome than room relative coords. Furthermore this could be a node instead.
|
|
||
| if (!_useWorldCoordinates || level.Session.MapData.Levels.FirstOrDefault(l => l.Name == _nextLevel) is not { } nextLevel) return; | ||
|
|
||
| _nearestSpawn += nextLevel.Position; |
Member
There was a problem hiding this comment.
I don't think this is right, TeleportTo takes dest room relative coordinates, so it should be subtracted instead.
| return; | ||
| } | ||
|
|
||
| if (!_useWorldCoordinates || level.Session.MapData.Levels.FirstOrDefault(l => l.Name == _nextLevel) is not { } nextLevel) return; |
Member
There was a problem hiding this comment.
We should fail the teleport entirely (and maybe warn the user) instead of delaying the crash to somewhere else if the _nextLevel doesn't exist.
| player, | ||
| _nextLevel, | ||
| _introType, | ||
| _nearestSpawn); |
Member
There was a problem hiding this comment.
It would be nice to allow for null values of _nearestSpawn since vanilla also implements that case.
maddie480-bot
added
2: changes requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale for this trigger is already described in the linked issue for this feature.
Some additional functionality added to the trigger not directly required to call Level.TeleportTo():