fix lua not load type in a safe manner

[wuke32767]

i got a zip that works

quirk.zip (compile it yourself)

[DashingCat]

The mod in the zip is:

• quirkModule.cs

using System;

namespace Celeste.Mod.quirk;

public class quirkModule : EverestModule
{
    [MonoMod.Game]
    class YetAnother;
    public override void Load()
    {
    }

    public override void Unload()
    {
    }
}

• Ruler.cs

using Mono.Cecil;
using System;

namespace MonoMod
{
    [MonoModCustomAttribute(nameof(MonoModRules.Start))]
    public class GameAttribute : Attribute;

    public class MonoModRules
    {
        public static void Start(TypeDefinition type, CustomAttribute __)
        {
            var m = type.Module;
            var scope = new AssemblyNameReference("can you get it", new(1, 0, 0, 0));
            var btype = m.ImportReference(new TypeReference("who cares", "missing name", null, scope));
            type.BaseType = btype;
        }
    }
}

When attempting to load the mod without the changes, when Everest starts, it crashes with the following exception:
System.IO.FileNotFoundException: Could not load file or assembly 'can you get it, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

It also logs the following line:
[Warn] [modasmctx] Failed to load assembly 'can you get it, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' for module 'quirk'

The exception does not show up when applying the changes, only leaving the warning.

If I understand correctly what is happening, the issue is that the non-public class YetAnother is getting cached by LuaLoader, which should not happen as the class is not public.

Did this behavior cause issue with existing or upcoming mods?

[wuke32767]

the only real-world program may be ILHookDebugger 0.99.9, if it's real-world program

i think it's because GetNestedTypes is trying to load a type that can't be loaded

[microlith57]

issue?: isn't this the same for nonpublic nested types? but on line 178 you have if (!type.IsNestedPublic) return null;

[wuke32767]

i think it's because of this?
https://github.com/EverestAPI/Everest/pull/1144/changes#diff-bbae25c1a7b486378c5e49ec58129d0d598ed1c682fe6920dd2fcf0a845dd5c6L78-L79

[microlith57]

hm, i see
so i guess you're at least not introducing a new problem lol

realistically i don't think this is a big deal since nested private types aren't used that much and it should be easy to change later if it turns out to be an issue ^_^

[microlith57]

yup

[maddie480-bot]

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Aug 23, 2026, 12:00 AM UTC, after which the pull request will be able to be merged.