rework LegacyHook IsLegacyMMCaller - #1135
Open
wuke32767 wants to merge 1 commit into
Open
Conversation
maddie480-bot
added
the
1: review needed
microlith57
approved these changes
Aug 16, 2026
microlith57
left a comment
microlith57
left a comment
Member
There was a problem hiding this comment.
i am happy with this, i don't think the cross mod hook util thing is a big concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relying on the stacktrace is not efficient and not safe.
jit may do tail call optimization, which can remove methods it should check from the stacktrace.
this branch doesn't check StackTrace, instead it simply checks hookDelegate a hook uses.
downside:
will someone use some hook helper from other mods?