Fix newbie messages not firing for new players on modern Paper - #6571
Open
JRoy wants to merge 1 commit into
Open
Fix newbie messages not firing for new players on modern Paper#6571JRoy wants to merge 1 commit into
JRoy wants to merge 1 commit into
Conversation
Player#hasPlayedBefore() is unreliable since the switch to configuration-phase events, as player data is persisted during login, so genuine first-joiners were treated as returning players. This broke EssentialsSpawn newbie spawn/kit/announce-format (EssentialsX#6466). Add a firstJoin flag to AsyncUserDataLoadEvent, derived from EssentialsX's own user data, and use it in EssentialsSpawn and EssentialsDiscord instead of hasPlayedBefore(). Fixes EssentialsX#6466
mdcfe
self-requested a review
June 14, 2026 22:10
mdcfe
requested changes
Aug 4, 2026
|
|
||
| // A null last account name means EssentialsX has never recorded this player before, i.e. it's their first join. | ||
| // We rely on EssentialsX's own user data here rather than Player#hasPlayedBefore(), which is unreliable on modern | ||
| // server platforms that persist player data during the login/configuration phase (see GH-6466, GH-6464). |
Member
There was a problem hiding this comment.
Use a link to the issues, not this Jira-esque syntax
| pluginManager.registerEvent(PlayerJoinEvent.class, playerListener, joinPriority, (ll, event) -> | ||
| ((EssentialsSpawnPlayerListener) ll).onPlayerJoin((PlayerJoinEvent) event), this); | ||
| // Listen on AsyncUserDataLoadEvent (fired after the core join flow) so we can reliably tell whether this is | ||
| // a player's first join, instead of using the unreliable Player#hasPlayedBefore() (see GH-6466). |
Member
There was a problem hiding this comment.
Ditto, also I'd rather we explained why hasPlayedBefore is "unreliable" inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player#hasPlayedBefore() is unreliable since the switch to configuration-phase events, as player data is persisted during login, so genuine first-joiners were treated as returning players. This broke EssentialsSpawn newbie spawn/kit/announce-format (#6466).
Add a firstJoin flag to AsyncUserDataLoadEvent, derived from EssentialsX's own user data, and use it in EssentialsSpawn and EssentialsDiscord instead of hasPlayedBefore().
Fixes #6466