Cache the Java serializer lookup per type - #1300
Merged
theigl merged 2 commits intoAug 20, 2026
Merged
Conversation
Collaborator
|
I'm wondering if we should replace this whole lookup with a private final ClassValue<JavaSerializer> javaSerializerByType = new ClassValue<>() {
protected JavaSerializer computeValue(Class<?> type) {
return isJavaSerializerRequired(type) ? new JavaSerializer() : null;
}
};Then the whole method just becomes: private JavaSerializer getJavaSerializerIfRequired (Class type) {
return javaSerializerByType.get(type);
}This is faster than the map lookup and much cleaner. |
Contributor
Author
|
This looks much better! I added one more commit with your suggestion. |
Collaborator
|
Thank you @vpaturet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #1299 by implementing the missing logic in the ExternalizableSerializer cache.