Repository navigation
perf(native): keep hover state local and drop offscreen passes - #450
Merged
Merged
Conversation
- VisionTable and LocalDataTable: the hover band observes its own state, so a pointer move no longer re-runs the table body, cells and layout. - Home: chart hover state lives in ChartSelectionScope, not the page. - Tooltips: the AppKit anchor view exists only while its control is hovered. - Shell: clip the detail column with a rectangle instead of a mask view. - Cards: no shadow cut-out mask under an opaque fill. - Buttons: shadow-sm is cast by the fill and only where a variant has one. - Topbar: no backdrop blur on the reduced tier or with Reduce Transparency.
EraPartner
force-pushed
the
claude/project-thread-1p1whz
branch
from
November 14, 2026 22:04
3867cf2 to
da97ff5
Compare
EraPartner
marked this pull request as ready for review
November 14, 2026 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by EraPartner · project thread
Summary
First round of a static performance audit of the Swift frontend (
apps/native/Sources/VisionNativeUI). Each change removes work SwiftUI or Core Animation did per pointer move or per composited frame. Nothing was measured: there is no Swift/SwiftUI toolchain for macOS in the cloud container, so every benefit below is reasoning from the code (inference), not a number.VisionTableHover,VisionTableHoverBand)Components/VisionTable.swifthoverYwas@Stateon the table: every pointer move re-ran the table body,content()for every cell,updateCache(which drops the plan) and the full table layoutRowHoverBand)Components/LocalDataTable.swiftAnyViewclosures)ChartSelectionScopeowns chart hover stateComponents/ChartSupport.swift,HomeView.swiftHomeViewbody; three unused@Statefields removedComponents/VisionTooltip.swiftclipShapeinstead of.maskon the detail column and the canvasShellRootView.swiftComponents/VisionCardLayers.swiftshadow-smcast by the fill, only on variants that have oneComponents/VisionButtonStyles.swift--cardon the reduced tier and with Reduce TransparencyComponents/NativeTopbar.swift:root.fx-reduced .app-topbar(backdrop-filter: none; background: hsl(var(--card)))Type of change
fix— bug fixfeat— new featurerefactor— no behavior changeperf— performancedocs— documentation onlychore/ci/test— tooling, build, or testsChecklist
bun run test) and lint is clean (bun run lint): not run locally; the CIswiftjob builds and tests the packagebun run typecheck): no TypeScript changedtype(scope): subject)console.log/ debug codedocs/pages updated (docs/architecture/native-app.md, new section "Swift redraw and layer optimisations")Architecture & data
Verification
swiftc -frontend -parse(swift:6.2-noble container) on the nine changed Swift files: exit 0. This checks syntax only; SwiftUI and AppKit do not exist on Linux, so type checking is left to the CIswiftjob.bun scripts/native-lint.ts:native-lint ok.Residual risk & follow-ups
Generated by Claude Code