Repository navigation
fix(native): market lookup ticks, symbol results and scorecard like the web (S-98) - #449
Merged
Merged
Conversation
Swift Charts' automatic date marks picked coarser steps than the web AreaChart's scaleTime().ticks(n), so the market lookup chart showed far fewer dates. TimeAxisTicks picks d3's calendar interval nearest span/count and aligns it as d3-time does (two-day steps restart each month). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QJtaMxiuFABVL2LiMKy5m
SymbolSearchResultItem: type-body ticker and name, outline badge for the type, px-3 py-2.5 rows. ScorecardPanel: grade badge, severity count pills and the concerns as an inset list with severity glyphs, value over benchmark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QJtaMxiuFABVL2LiMKy5m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by EraPartner · project thread
Summary
UI audit row S-98 (Market lookup), with the TS app as the reference:
TimeAxisTicks(VisionNativeCore) reproduces d3scaleTime().ticks(n). It picks the calendar interval closest to span/count and aligns ticks as d3-time does. The market chart uses it instead of.automatic(desiredCount:), which picked coarser steps.ResearchUIComponents.swift): matchSymbolSearchResultItem. The ticker and name use type-body, the type is an outlineBadge size="sm", the exchange is type-footnote, and rows use px-3 py-2.5 with rounded-control.ResearchMarketDetailViews.swift): matchesScorecardPanel. It shows the grade badge (score and grade), the severity count pills, and the concerns as an insetListof rows. Each row has a severity glyph, the metric over its reason, and the value over its benchmark.S-16 (Home column gap) and K4 (hues) need no code change; see the thread for what was checked.
Type of change
fix— bug fixChecklist
Verification
TimeAxisTicksTests(4 tests) pass in a Linuxswift:6.2-noblecontainer on a scratch package holding onlyTimeAxisTicks.swift. The first run found the two-day month-boundary bug; it is fixed in this PR. That run is Linux only, not CI.swiftjob. The UI changes are unverified on a Mac.Generated by Claude Code