Repository navigation
perf(native): re-measure a table only when the hover band changes row - #448
Merged
Merged
Conversation
The table hover band tracked the pointer's y, so every pointer move changed the layout and re-measured the whole table. It now tracks the hovered row index, read from the row bounds of the last placement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QJtaKt8X8tTpztJkkqNjD
EraPartner
marked this pull request as ready for review
November 14, 2026 21:51
EraPartner
enabled auto-merge (squash)
November 14, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by EraPartner · project thread
Summary
VisionTable's hover band tracked the pointer's y. Every pointer move changed a layout property, which reset the layout cache and re-measured every cell. The view now maps the pointer to a row index (from the row bounds of the last placement, kept in a reference box) and passes only that index to the layout, so the table is re-measured only when the pointer crosses into another row. The look is unchanged.The second review item (sankey hover hit areas) was already fixed on main by #446 (one tracker that hit-tests node rectangles and stroked band outlines), so this PR does not touch it.
Type of change
perf— performanceChecklist
bun scripts/native-lint.ts:native-lint ok)Architecture & data
Verification
bun scripts/native-lint.ts:native-lint okswiftCI job is the compile check. Not looked at on a Mac.Residual risk & follow-ups
Generated by Claude Code