docs(pgd): Clarify origin_node_group matching semantics for 5.9 and 6.4#7187
Merged
Conversation
In 5.9 the GUC-override path matched only the node's own group, while the default_commit_scope path walked ancestors — an asymmetry that caused silent async fallback when SET LOCAL bdr.commit_scope was used with a scope defined on a parent group. In 6.4 the GUC path was fixed to also walk ancestors (commit 776e243b13), so both paths now behave consistently. Replace the vague "directly or indirectly related" sentence in both versions with precise, version-accurate descriptions. The 5.9 entry explains the route-dependent split and adds a warning callout for the silent-fallback trap. The 6.4 entry describes the unified ancestor-walk behaviour. BDR-7611
mpfuster
added
deploy
Contributor
|
Thanks @irionr , do you need we need to port the note you added for 5.9 all throughout the following versions up to 6.4? |
Contributor
Author
probably yes, the change is only from 6.4 onwards |
Contributor
Author
event hough , we have the latest minors updated I think it's fine like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 5.9 the GUC-override path matched only the node's own group, while the default_commit_scope path walked ancestors — an asymmetry that caused silent async fallback when SET LOCAL bdr.commit_scope was used with a scope defined on a parent group. In 6.4 the GUC path was fixed to also walk ancestors (commit 776e243b13), so both paths now behave consistently.
Replace the vague "directly or indirectly related" sentence in both versions with precise, version-accurate descriptions. The 5.9 entry explains the route-dependent split and adds a warning callout for the silent-fallback trap. The 6.4 entry describes the unified ancestor-walk behaviour.
BDR-7611
Tip
Draft deployment: https://deploy-preview-7187--edb-docs-staging.netlify.app/docs/