Refactor block material - #2997
Open
TomyLobo wants to merge 2 commits into
Open
Conversation
TomyLobo
commented
Aug 2, 2026
TomyLobo
commented
Collaborator
- Add BlockState.getMaterial()
- Add ShapeType parameter to BlockMaterial.isFullCube
This was referenced Aug 2, 2026
octylFractal
requested changes
Aug 3, 2026
| ] | ||
| } | ||
| ], | ||
| "Why on earth is this even an issue?": [ |
Member
There was a problem hiding this comment.
If someone was implementing BlockMaterial, this can sometimes cause weird issues that I don't recall exactly. But we should have the actual reasoning here, e.g.
Suggested change
| "Why on earth is this even an issue?": [ | |
| "No one should be implementing BlockMaterial": [ |
|
|
||
| import java.util.EnumSet; | ||
|
|
||
| public abstract class AbstractBlockMaterial<VS> implements BlockMaterial { |
Member
There was a problem hiding this comment.
Instead of having a VS parameter, can we just push getShape into isShapeFullBlock? There doesn't really seem to be an advantage to having it here.
Also, we should probably just call isShapeFullBlock -> isFullCubeUncached?
Comment on lines
+22
to
+24
| public enum ShapeType { | ||
| SHAPE, | ||
| VISUAL_SHAPE, |
Member
There was a problem hiding this comment.
This should explain what the difference is, and what a ShapeType is generally -- i.e., all members and the class should be documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.