Repository navigation
PLAT-3409 Added genrule to detect system resources - #454
Open
NicolasHuertas wants to merge 4 commits into
Open
NicolasHuertas wants to merge 4 commits into
NicolasHuertas wants to merge 4 commits into
Conversation
NicolasHuertas
marked this pull request as draft
September 25, 2026 18:07
NicolasHuertas
marked this pull request as ready for review
September 25, 2026 18:24
NicolasHuertas
changed the title
Contributor
Author
|
I added some more metadata to the aws_instance_type and gap_machine_type genrules so it shows:
To test, we can run Is there anything else that would be useful to add? |
anfelbar
reviewed
Oct 9, 2026
Comment on lines
+72
to
+89
| genrule( | ||
| name = "get_aws_instance_type", | ||
| outs = ["aws_instance.txt"], | ||
| # Fetches key AWS instance metadata for performance comparison | ||
| cmd = "(" + | ||
| "TOKEN=$$(curl -s -X PUT 'http://169.254.169.254/latest/api/token' -H 'X-aws-ec2-metadata-token-ttl-seconds: 21600') && " + | ||
| "echo '=== AWS Instance Metadata ===' && " + | ||
| "echo 'Instance Type:' && " + | ||
| "curl -s -H \"X-aws-ec2-metadata-token: $$TOKEN\" http://169.254.169.254/latest/meta-data/instance-type && echo '' && " + | ||
| "echo 'AMI ID:' && " + | ||
| "curl -s -H \"X-aws-ec2-metadata-token: $$TOKEN\" http://169.254.169.254/latest/meta-data/ami-id && echo '' && " + | ||
| "echo 'Availability Zone:' && " + | ||
| "curl -s -H \"X-aws-ec2-metadata-token: $$TOKEN\" http://169.254.169.254/latest/meta-data/placement/availability-zone && echo '' && " + | ||
| "echo 'Instance Lifecycle:' && " + | ||
| "curl -s -H \"X-aws-ec2-metadata-token: $$TOKEN\" http://169.254.169.254/latest/meta-data/instance-life-cycle && echo '' && " + | ||
| "echo 'Instance ID:' && " + | ||
| "curl -s -H \"X-aws-ec2-metadata-token: $$TOKEN\" http://169.254.169.254/latest/meta-data/instance-id" + | ||
| ") > $@ 2>&1 || echo 'Not AWS or unavailable' > $@", |
Collaborator
There was a problem hiding this comment.
These are a lot of curls. What about using ec2-metadata --all?
Contributor
Author
There was a problem hiding this comment.
That command doesn't seem to be installed in the remote execution container, but it works after downloading the shell script. I've updated the genrule to do that and also made a recursive query for the GCP genrule.
anfelbar
approved these changes
Oct 14, 2026
anfelbar
left a comment
anfelbar
left a comment
Collaborator
There was a problem hiding this comment.
One final thing. Is it possible to delete the aws downloaded binary at the end of the execution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
//genrules:remote_exec_infoon a bezel test command outputs:To test with a specific example, like EngFlow's simple Java example, run: