Repository navigation
Match configure_file case-insensitively in the trace extractor - #36
Open
anakanemison wants to merge 1 commit into
Open
anakanemison wants to merge 1 commit into
anakanemison wants to merge 1 commit into
Conversation
CMake command names are case-insensitive, and --trace reports the spelling the CMakeLists used. extract_configure.py compared the event's "cmd" with the lowercase "configure_file" only, so every CONFIGURE_FILE(...) call was dropped from configured_files without a trace. Measured in any2bazel-lab: on a MySQL Server reference configure, 167 of 219 configure_file events were uppercase and went unrecorded. The model listed one configured file, and my_config.h, which the whole build includes, was not among them. lensfun also spells the command in capitals, which explains why its two configure_file outputs were missing from its model. Lower-case the event's command before comparing. No other trace command is matched by name in the extractors today. No migration run exercised this change; it was checked on the stored MySQL trace. Lab-Proposal: P15 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 23 of a stacked series (tracking issue: #35). Based on
main.Kind: fix. Lab proposal: P15.
What the migration runs showed
CMake commands are case-insensitive. On mysql-server's reference trace, 167
CONFIGURE_FILEevents against 52configure_file, and the model recorded 1 configured file;my_config.h, which the whole build depends on, was missing. Checked offline on the stored trace.The change
CMake command names are case-insensitive, and --trace reports the spelling
the CMakeLists used. extract_configure.py compared the event's "cmd" with
the lowercase "configure_file" only, so every CONFIGURE_FILE(...) call was
dropped from configured_files without a trace.
Measured in any2bazel-lab: on a MySQL Server reference configure, 167 of
219 configure_file events were uppercase and went unrecorded. The model
listed one configured file, and my_config.h, which the whole build
includes, was not among them. lensfun also spells the command in capitals,
which explains why its two configure_file outputs were missing from its
model.
Lower-case the event's command before comparing. No other trace command is
matched by name in the extractors today. No migration run exercised this
change; it was checked on the stored MySQL trace.
Testing
pytest tests/at this commit: 132 passed (130 onmain).🤖 Generated with Claude Code