fix(ios): Preserve dSYMs in thinned size analysis uploads - #837
Merged
Conversation
📲 Install BuildsiOS
|
jamieQ
changed the title
jamieQ
marked this pull request as ready for review
August 5, 2026 16:46
trevor-e
approved these changes
Aug 5, 2026
| end | ||
|
|
||
| desc 'Replace the app in an XCArchive with the app from a device-thinned IPA' | ||
| private_lane :replace_xcarchive_app_with_thinned_ipa do |options| |
Collaborator
There was a problem hiding this comment.
nit: this assumes the IPA is thinned but technically could work with any IPA right? just wondering if the naming could be simplified to replace_xcarchive_app_with_ipa
| unless xcarchive_app_paths.one? | ||
| UI.user_error!("Expected one app in the XCArchive, found #{xcarchive_app_paths.length}") | ||
| end | ||
| xcarchive_app_path = xcarchive_app_paths.first |
Collaborator
There was a problem hiding this comment.
The app folder usually contains one app but I've seen multiple before, you might want to do an exact or fuzzy search by name here.
| ) | ||
|
|
||
| UI.success("Replaced the XCArchive app with the thinned app: #{xcarchive_app_path}") | ||
| xcarchive_path |
Collaborator
There was a problem hiding this comment.
nit: returning the path might be unnecessary since this is just returning the input? otherwise it reads a little misleading to me that it's doing more than it is.
Collaborator
Author
There was a problem hiding this comment.
True. Yeah, will drop this.
jamieQ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #835. The change in #835 to upload a thinned IPA for size analysis "worked", but unfortunately lost dSYM info. Upon further investigation, it appears we used to have both things working (implemented in #606), but that regressed recently. This change re-implements an approach closer to the original strategy, where we produce a thinned export, but then replace the original XCArchive payload with the thinned payload before uploading. This way we upload the thinned payload and retain the dSYM through the process.
Now the uploads have debug info in the binary analysis:
Refs EME-1285