Skip to content

fix(aurabuff): hide the pet reminder while mounted - #1376

Open
Trenchfoote wants to merge 1 commit into
EllesmereGaming:mainfrom
Trenchfoote:fix/pet-reminder-while-mounted
Open

fix(aurabuff): hide the pet reminder while mounted#1376
Trenchfoote wants to merge 1 commit into
EllesmereGaming:mainfrom
Trenchfoote:fix/pet-reminder-while-mounted

Conversation

@Trenchfoote

Copy link
Copy Markdown
Contributor

Mounting in the open world auto-dismisses the pet, so the "pet not summoned" reminder appeared for the whole ride and cleared itself on dismount when the pet returned. Skyriding already hid it, because the reminder pass suppresses everything while mounted and flying, which made the warning look inconsistent as well as wrong.

A pet cannot be summoned while mounted in any case, so the reminder is never actionable there. This matches the Pet on Passive reminder in the same block, which already skips while mounted for the same reason.

PLAYER_MOUNT_DISPLAY_CHANGED is already registered, so mounting and dismounting re-evaluate the reminder with no new events.

What does this PR do?

How was it tested?

Screenshots

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game, works on live retail; no load errors on the 12.1 PTR client

Mounting in the open world auto-dismisses the pet, so the "pet not
summoned" reminder appeared for the whole ride and cleared itself on
dismount when the pet returned. Skyriding already hid it, because the
reminder pass suppresses everything while mounted and flying, which made
the warning look inconsistent as well as wrong.

A pet cannot be summoned while mounted in any case, so the reminder is
never actionable there. This matches the Pet on Passive reminder in the
same block, which already skips while mounted for the same reason.

PLAYER_MOUNT_DISPLAY_CHANGED is already registered, so mounting and
dismounting re-evaluate the reminder with no new events.
Copilot AI lite review requested due to automatic review settings August 13, 2026 00:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an AuraBuffReminders UX issue where the “pet not summoned” reminder could appear while the player is mounted in the open world (a state where summoning a pet is not actionable), aligning its behavior with the existing “Pet on Passive” reminder logic.

Changes:

  • Suppresses the “pet not summoned” reminder when IsMounted() is true.
  • Keeps reminder refresh event-driven using the already-registered PLAYER_MOUNT_DISPLAY_CHANGED (no new events needed).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants