fix(aurabuff): hide the pet reminder while mounted - #1376
Open
Trenchfoote wants to merge 1 commit into
Open
Conversation
Mounting in the open world auto-dismisses the pet, so the "pet not summoned" reminder appeared for the whole ride and cleared itself on dismount when the pet returned. Skyriding already hid it, because the reminder pass suppresses everything while mounted and flying, which made the warning look inconsistent as well as wrong. A pet cannot be summoned while mounted in any case, so the reminder is never actionable there. This matches the Pet on Passive reminder in the same block, which already skips while mounted for the same reason. PLAYER_MOUNT_DISPLAY_CHANGED is already registered, so mounting and dismounting re-evaluate the reminder with no new events.
There was a problem hiding this comment.
Pull request overview
This PR fixes an AuraBuffReminders UX issue where the “pet not summoned” reminder could appear while the player is mounted in the open world (a state where summoning a pet is not actionable), aligning its behavior with the existing “Pet on Passive” reminder logic.
Changes:
- Suppresses the “pet not summoned” reminder when
IsMounted()is true. - Keeps reminder refresh event-driven using the already-registered
PLAYER_MOUNT_DISPLAY_CHANGED(no new events needed).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mounting in the open world auto-dismisses the pet, so the "pet not summoned" reminder appeared for the whole ride and cleared itself on dismount when the pet returned. Skyriding already hid it, because the reminder pass suppresses everything while mounted and flying, which made the warning look inconsistent as well as wrong.
A pet cannot be summoned while mounted in any case, so the reminder is never actionable there. This matches the Pet on Passive reminder in the same block, which already skips while mounted for the same reason.
PLAYER_MOUNT_DISPLAY_CHANGED is already registered, so mounting and dismounting re-evaluate the reminder with no new events.
What does this PR do?
How was it tested?
Screenshots
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames