feat(cdm): accept 'all' in Ticks at Stacks - #1374
Merged
Merged
Conversation
Typing 'all' in the Tracking Bars 'Ticks at Stacks' input now places a tick at every stack (N stacks give N-1 interior divisions, matching the charge hash line convention) instead of requiring a hand-typed list that has to be redone whenever Max Stacks changes. The keyword is parsed in ParseTickValues, the single place the field is read. Numeric lists take the exact same code path as before, so existing saved values render identically and no migration is needed. The 'Ticks at Stacks' label gains a tooltip documenting the keyword; the translated '(Ex: 1,5,8)' locale key is left untouched so no translations are orphaned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cooldown Manager -> Tracking Bars -> "Ticks at Stacks" now accepts the keyword
allin addition to a comma-separated list. Typingallputs a tick at everystack, so a bar with Max Stacks 10 no longer needs
1,2,3,4,5,6,7,8,9typed outby hand and retyped every time the Max Stacks slider moves.
How was it tested?
Retail live, 12.1. Enabled Max Stacks on a stack-tracking bar, entered
all,confirmed evenly spaced ticks in both the options preview and on the live bar,
and confirmed the tick count follows the Max Stacks slider without retyping.
Screenshots
Checklist
setting; the existing field defaults to
""and only behaves differentlyonce a user types the keyword
work, no frames built - the expansion runs only when the token is present
per-frame allocations) -
ApplyTBBTickMarksruns from the skin/apply passand the
_ticksDirtyone-shot consumers, never OnUpdate; the loop isbounded by the Max Stacks slider cap of 100, and tick textures come from
the existing per-bar cache
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames -N/A, pure Lua string/number handling on addon-owned frames; no game API touched