Skip to content

Locales: koKR update -- new keys, section reorganization - #1298

Closed
labrie75 wants to merge 1 commit into
EllesmereGaming:mainfrom
labrie75:Locales-koKR-update----new-keys,-section-reorganization
Closed

Locales: koKR update -- new keys, section reorganization#1298
labrie75 wants to merge 1 commit into
EllesmereGaming:mainfrom
labrie75:Locales-koKR-update----new-keys,-section-reorganization

Conversation

@labrie75

@labrie75 labrie75 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

koKR-only update to Locales/koKR.lua. No code changes.

Area Change
New keys +61 (no keys removed, English untouched)
Reorganization keys previously appended at the file bottom moved into their -- == add <Module> sections
Consistency a few existing values reworded to match in-game terms (commented inline)

Added

  • Unit Frames: "Show Tooltip For" checkbox-dropdown items and tooltips
  • Cooldown Manager: Reverse Fill / Fill Up / out-of-combat hide tooltips
  • Resource Bars: Smooth Bar Animation, GCD bar "Show Fill Color When Idle"
  • Unlock Mode: "(Width/Height) matched to (bar). Unmatch in Unlock Mode to edit." -- the source builds this by concatenation, so the common axis x bar-name combinations are registered as full-string keys
  • Minimap: Addon Compartment toggle/scale/tooltip
  • Chat: tab cog popups (Tab Layout / Tab Background / Active Tab Background)
  • Bags: Sort Options cog, QoL: Hold Capped Artisan Payouts, Party Mode: Spin cog
  • Chat prints: a dedicated section at the bottom collecting every user-facing
    chat message (print / EllesmereUI.Print / instance-reset SendChatMessage
    defaults). Keys are exact source literals incl. color codes. Messages whose
    call sites are not yet L-wrapped are data-only for now and light up with a
    future wrapping PR; the already-wrapped ones (Raid Tools, auto-repair,
    auto-sell) translate immediately.

Changed (existing values, inline-commented)

  • "Raid" prefix on Raid Tools strings now matches the tab name (레이드 -> 공격대)
  • Pull timer strings unified to 초읽기 (countdown) across Raid Tools and CDM
  • "Offset" values unified to 위치 (position), matching X/Y Offset keys
  • "Match Damage Meters" shortened so it fits the dropdown width

Reorganized

  • Keys that had accumulated after the M+ abbreviation block are distributed
    into their module sections; the M+ keystone block stays last.

How was it tested?

Loaded on the 12.1 PTR with a koKR client: options panel pages for Unit
Frames, CDM, Resource Bars, Minimap, Chat, Bags, QoL and Party Mode render the
new strings; terminology changes verified on the Raid Tools tab. File parses
clean; 0 keys removed, so every previously translated string is unchanged
unless listed above.

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game, works on live retail; no load errors on the 12.1 PTR client

@labrie75 labrie75 closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant